Replace const pointer with const reference in type functions (#3430)

manh9203 · web-flow · commit 36ff4da73ba9 · 2024-05-03T16:51:18.000-04:00
* Change functions definition

* Change return type to object

* Change ListType

* Change ArrayType

* Change StructType

* Change MapType

* Change UnionType

* Fix pytest

* Fix rust test
diff --git a/src_cpp/node_util.cpp b/src_cpp/node_util.cpp
@@ -196,7 +196,7 @@ Napi::Value Util::ConvertToNapiObject(const Value& value, Napi::Env env) {
     }
     case LogicalTypeID::STRUCT:
     case LogicalTypeID::UNION: {
-        auto childrenNames = StructType::getFieldNames(dataType);
+        auto childrenNames = StructType::getFieldNames(*dataType);
         auto napiObj = Napi::Object::New(env);
         auto size = NestedVal::getChildrenSize(&value);
         for (auto i = 0u; i < size; ++i) {

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ Napi::Value Util::ConvertToNapiObject(const Value& value, Napi::Env env) {`
`196`	`196`	`}`
`197`	`197`	`case LogicalTypeID::STRUCT:`
`198`	`198`	`case LogicalTypeID::UNION: {`
`199`		`- auto childrenNames = StructType::getFieldNames(dataType);`
	`199`	`+ auto childrenNames = StructType::getFieldNames(*dataType);`
`200`	`200`	`auto napiObj = Napi::Object::New(env);`
`201`	`201`	`auto size = NestedVal::getChildrenSize(&value);`
`202`	`202`	`for (auto i = 0u; i < size; ++i) {`