unique_ptr<LogicalType> to LogicalType change (#3647)

mxwli · web-flow · commit 36e8acd76cb3 · 2024-06-19T16:02:36.000-04:00
diff --git a/src_cpp/node_util.cpp b/src_cpp/node_util.cpp
@@ -86,8 +86,8 @@ Napi::Value Util::ConvertToNapiObject(const Value& value, Napi::Env env) {
     if (value.isNull()) {
         return env.Null();
     }
-    auto dataType = value.getDataType();
-    auto dataTypeID = dataType->getLogicalTypeID();
+    const auto& dataType = value.getDataType();
+    auto dataTypeID = dataType.getLogicalTypeID();
     switch (dataTypeID) {
     case LogicalTypeID::BOOL: {
         return Napi::Boolean::New(env, value.getValue<bool>());
@@ -196,7 +196,7 @@ Napi::Value Util::ConvertToNapiObject(const Value& value, Napi::Env env) {
     }
     case LogicalTypeID::STRUCT:
     case LogicalTypeID::UNION: {
-        auto childrenNames = StructType::getFieldNames(*dataType);
+        auto childrenNames = StructType::getFieldNames(dataType);
         auto napiObj = Napi::Object::New(env);
         auto size = NestedVal::getChildrenSize(&value);
         for (auto i = 0u; i < size; ++i) {
@@ -271,7 +271,7 @@ Napi::Value Util::ConvertToNapiObject(const Value& value, Napi::Env env) {
         return ConvertRdfVariantToNapiObject(value, env);
     }
     default:
-        throw Exception("Unsupported type: " + dataType->toString());
+        throw Exception("Unsupported type: " + dataType.toString());
     }
     return Napi::Value();
 }

Original file line number	Diff line number	Diff line change
`@@ -86,8 +86,8 @@ Napi::Value Util::ConvertToNapiObject(const Value& value, Napi::Env env) {`
`86`	`86`	`if (value.isNull()) {`
`87`	`87`	`return env.Null();`
`88`	`88`	`}`
`89`		`- auto dataType = value.getDataType();`
`90`		`- auto dataTypeID = dataType->getLogicalTypeID();`
	`89`	`+ const auto& dataType = value.getDataType();`
	`90`	`+ auto dataTypeID = dataType.getLogicalTypeID();`
`91`	`91`	`switch (dataTypeID) {`
`92`	`92`	`case LogicalTypeID::BOOL: {`
`93`	`93`	`return Napi::Boolean::New(env, value.getValue<bool>());`
`@@ -196,7 +196,7 @@ Napi::Value Util::ConvertToNapiObject(const Value& value, Napi::Env env) {`
`196`	`196`	`}`
`197`	`197`	`case LogicalTypeID::STRUCT:`
`198`	`198`	`case LogicalTypeID::UNION: {`
`199`		`- auto childrenNames = StructType::getFieldNames(*dataType);`
	`199`	`+ auto childrenNames = StructType::getFieldNames(dataType);`
`200`	`200`	`auto napiObj = Napi::Object::New(env);`
`201`	`201`	`auto size = NestedVal::getChildrenSize(&value);`
`202`	`202`	`for (auto i = 0u; i < size; ++i) {`
`@@ -271,7 +271,7 @@ Napi::Value Util::ConvertToNapiObject(const Value& value, Napi::Env env) {`
`271`	`271`	`return ConvertRdfVariantToNapiObject(value, env);`
`272`	`272`	`}`
`273`	`273`	`default:`
`274`		`- throw Exception("Unsupported type: " + dataType->toString());`
	`274`	`+ throw Exception("Unsupported type: " + dataType.toString());`
`275`	`275`	`}`
`276`	`276`	`return Napi::Value();`
`277`	`277`	`}`