java tests: fix path resolution and BigDecimal value comparison

adsharma · adsharma · commit f1fc348e001b · 2026-03-31T11:44:08.000-07:00
Pass the Gradle project directory to tests as the ladybug.projectDir
system property so TestHelper can build absolute paths to dataset files
regardless of the working directory at test time.

ValueTest.testCreateValue: BigDecimal comparison now uses compareTo()
instead of equals() to handle scale differences (e.g. 1.5 vs 1.50).
Also fix two places in the map test loop that reused a stale LbugMap
reference instead of constructing a fresh one from the current tuple.
diff --git a/build.gradle b/build.gradle
@@ -130,6 +130,7 @@ tasks.sourcesJar {
 
 test {
     useJUnitPlatform()
+    systemProperty 'ladybug.projectDir', projectDir.absolutePath
     testLogging {
         events 'passed', 'skipped', 'failed'
         exceptionFormat = 'full'
diff --git a/src/test/java/com/lbugdb/TestHelper.java b/src/test/java/com/lbugdb/TestHelper.java
@@ -3,13 +3,17 @@
 import java.io.BufferedReader;
 import java.io.FileReader;
 import java.io.IOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
 public class TestHelper {
     private static Database db;
     private static Connection conn;
-    private final static String tinysnbDir = "../../dataset/tinysnb/";
+    private static final Path projectDir = Paths.get(System.getProperty("ladybug.projectDir", "."));
+    private static final Path tinysnbDir = projectDir.resolve("../../dataset/tinysnb").normalize();
+    private static final Path tinysnbSerialDir = projectDir.resolve("../../dataset/tinysnb-serial").normalize();
     private final static String extensions = "csv|parquet|npy|ttl|nq|json|lbug_extension";
     private final static Pattern dataFileRegex = Pattern.compile("\"([^\"]+\\.(" + extensions + "))\"", Pattern.CASE_INSENSITIVE);
 
@@ -28,7 +32,7 @@ public static void loadData(String dbPath) throws IOException {
 
         String line;
 
-        reader = new BufferedReader(new FileReader(tinysnbDir + "schema.cypher"));
+        reader = new BufferedReader(new FileReader(tinysnbDir.resolve("schema.cypher").toFile()));
         while ((line = reader.readLine()) != null) {
             line = line.trim();
             if (line.isEmpty()) {
@@ -40,7 +44,7 @@ public static void loadData(String dbPath) throws IOException {
         reader.close();
 
 
-        reader = new BufferedReader(new FileReader(tinysnbDir + "copy.cypher"));
+        reader = new BufferedReader(new FileReader(tinysnbDir.resolve("copy.cypher").toFile()));
         while ((line = reader.readLine()) != null) {
             line = line.trim();
             if (line.isEmpty()) {
@@ -49,7 +53,7 @@ public static void loadData(String dbPath) throws IOException {
 
             // handle multiple data files in one statement
             Matcher matcher = dataFileRegex.matcher(line);
-            String statement = matcher.replaceAll("\"" + tinysnbDir + "$1\"");
+            String statement = matcher.replaceAll("\"" + tinysnbDir.resolve("$1").normalize() + "\"");
 
             try (QueryResult result = conn.query(statement)) {}
         }
@@ -59,7 +63,8 @@ public static void loadData(String dbPath) throws IOException {
         try (QueryResult result = conn.query("create node table moviesSerial (ID SERIAL, name STRING, length INT32, note STRING, PRIMARY KEY (ID));")) {
         }
 
-        try (QueryResult result = conn.query("copy moviesSerial from \"../../dataset/tinysnb-serial/vMovies.csv\"")) {
+        try (QueryResult result = conn.query("copy moviesSerial from \"" +
+                tinysnbSerialDir.resolve("vMovies.csv").normalize() + "\"")) {
         }
     }
 }
diff --git a/src/test/java/com/lbugdb/ValueTest.java b/src/test/java/com/lbugdb/ValueTest.java
@@ -22,7 +22,17 @@ void checkValueConversion(Value val) {
             QueryResult result = conn.execute(preparedStatement, parameters);
             if (result.hasNext()) {
                 Value cur = result.getNext().getValue(0);
-                assertTrue(val.isNull() && cur.isNull() || val.getValue().equals(cur.getValue()));
+                if (val.isNull() || cur.isNull()) {
+                    assertTrue(val.isNull() && cur.isNull());
+                    return;
+                }
+                Object expected = val.getValue();
+                Object actual = cur.getValue();
+                if (expected instanceof BigDecimal && actual instanceof BigDecimal) {
+                    assertEquals(0, ((BigDecimal) expected).compareTo((BigDecimal) actual));
+                } else {
+                    assertTrue(val.isNull() && cur.isNull() || expected.equals(actual));
+                }
             }
         }
     }
@@ -1522,6 +1532,7 @@ void MapValGetKey() {
 
         flatTuple = result.getNext();
         value = flatTuple.getValue(0);
+        mapVal = new LbugMap(value);
         assertTrue(value.isOwnedByCPP());
         key = mapVal.getKey(0);
         assertNull(key);
@@ -1530,6 +1541,7 @@ void MapValGetKey() {
 
         flatTuple = result.getNext();
         value = flatTuple.getValue(0);
+        mapVal = new LbugMap(value);
         assertTrue(value.isOwnedByCPP());
         key = mapVal.getKey(0);
         fieldName = key.getValue();
