Skip to content
This repository was archived by the owner on Jul 31, 2022. It is now read-only.
This repository was archived by the owner on Jul 31, 2022. It is now read-only.

Throttled Handler doesn't delete failed handle connections #88

Closed
Closed
Throttled Handler doesn't delete failed handle connections#88
Assignees
Katsute
Labels
bugSomething isn't working as expected
@Katsute

Description

@Katsute
Katsute
opened on Aug 11, 2020

Prerequisites

If all checks are not passed then the issue will be closed

  • I have checked that no other similar issue already exists

Operating System: Operating system name and version
Windows 10

Release Version: Release version or branch where the issue occurred
03.05.06

Issue

Explain your issue. Add any screenshots here

If an exception is thrown in #handle the connection will not be deleted, despite being handled. This can cause ghost connections.

simplehttpserver/src/main/java/com/kttdevelopment/simplehttpserver/handler/ThrottledHandler.java

Lines 43 to 51 in 77e9449

@Override
public final void handle(final HttpExchange exchange) throws IOException{
if(throttler.addConnection(exchange)){
handler.handle(exchange);
throttler.deleteConnection(exchange);
}else{
exchange.close();
}
}

Expected Behavior

Explain what was supposed to happen

Connections should be deleted after handle (use a try finally).

Steps To Reproduce

Explain how and/or when the error occurred

Throw an exception in throttled handler.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working as expected

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions