Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Kludex/starlette
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.36.3
Choose a base ref
...
head repository: Kludex/starlette
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.37.0
Choose a head ref
  • 9 commits
  • 14 files changed
  • 4 contributors

Commits on Feb 4, 2024

  1. Added type annotations to test_exceptions.py (#2479)

    Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan>
    TechNiick and Scirlat Danut authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    fce2809 View commit details
    Browse the repository at this point in the history
  2. Added type annotations to test_datastructures.py (#2477)

    Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan>
    TechNiick and Scirlat Danut authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    b817dc4 View commit details
    Browse the repository at this point in the history
  3. added type annotations to test_http_redirect.py (#2465)

    Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan>
    TechNiick and Scirlat Danut authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    5ab70d8 View commit details
    Browse the repository at this point in the history
  4. Added type annotations to test_config.py (#2475)

    * added type annotations to test_config.py
    
    * Apply suggestions from code review
    
    ---------
    
    Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan>
    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    3 people authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    551bf86 View commit details
    Browse the repository at this point in the history
  5. Added type annotations to test_convertors.py (#2476)

    * added type annotations to test_convertors.py
    
    * Apply suggestions from code review
    
    ---------
    
    Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan>
    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    3 people authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    043c800 View commit details
    Browse the repository at this point in the history
  6. Support the WebSocket Denial Response ASGI extension (#2041)

    * supply asgi_extensions to TestClient
    
    * Add WebSocket.send_response()
    
    * Add response support for WebSocket testclient
    
    * fix test for filesystem line-endings
    
    * lintint
    
    * support websocket.http.response extension by default
    
    * Improve coverate
    
    * Apply suggestions from code review
    
    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    
    * Undo unrelated change
    
    * fix incorrect error message
    
    * Update starlette/websockets.py
    
    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    
    * formatting
    
    * Re-introduce close-code and close-reason to WebSocketReject
    
    * Make sure the "websocket.connect" message is received in tests
    
    * Deliver a websocket.disconnect message to the app even if it closes/rejects itself.
    
    * Add test for filling out missing `websocket.disconnect` code
    
    * Add rejection headers.  Expand tests.
    
    * Fix types, headers in message are `bytes` tuples.
    
    * Minimal WebSocket Denial Response implementation
    
    * Revert "Minimal WebSocket Denial Response implementation"
    
    This reverts commit 7af10dd.
    
    * Rename to send_denial_response and update documentation
    
    * Remove the app_disconnect_msg.  This can be added later in a separate PR
    
    * Remove status code 1005 from this PR
    
    * Assume that the application has tested for the extension before sending websocket.http.response.start
    
    * Rename WebSocketReject to WebSocketDenialResponse
    
    * Remove code and status from WebSocketDenialResponse.
    Just send a regular WebSocketDisconnect even when connection is rejected with close()
    
    * Raise an exception if attempting to send a http response and server does not support it.
    
    * WebSocketDenialClose and WebSocketDenialResponse
    These are both instances of WebSocketDenial.
    
    * Update starlette/testclient.py
    
    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    
    * Revert "WebSocketDenialClose and WebSocketDenialResponse"
    
    This reverts commit 71b76e3.
    
    * Rename parameters, member variables
    
    * Use httpx.Response as the base for WebSocketDenialResponse.
    
    * Apply suggestions from code review
    
    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    
    * Update sanity check message
    
    * Remove un-needed function
    
    * Expand error message test regex
    
    * Add type hings to test methods
    
    * Add doc string to test.
    
    * Fix mypy complaining about mismatching parent methods.
    
    * nitpick & remove test
    
    * Simplify the documentation
    
    * Update starlette/testclient.py
    
    * Update starlette/testclient.py
    
    * Remove an unnecessary test
    
    * there is no special "close because of rejection" in the testclient anymore.
    
    ---------
    
    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    kristjanvalur and Kludex authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    93e74a4 View commit details
    Browse the repository at this point in the history
  7. Added type annotations to test_error.py (#2462)

    * added type annotations to test_error.py
    
    * Apply suggestions from code review
    
    ---------
    
    Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan>
    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    3 people authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    c158ef4 View commit details
    Browse the repository at this point in the history
  8. Added type annotations to test_endpoints.py (#2478)

    * added type annotations to test_endpoints.py
    
    * Apply suggestions from code review
    
    ---------
    
    Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan>
    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    3 people authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    5253156 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Version 0.37.0 (#2457)

    Kludex authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    6fcd579 View commit details
    Browse the repository at this point in the history
Loading