Avoid blocking on failed connections at shutdown.

olim7t · olim7t · commit 015bcfe63c81 · 2015-03-30T15:59:46.000+02:00
This is a workaround for Netty bug 3464, which will be fixed in
4.0.27.Final.
diff --git a/driver-core/src/main/java/com/datastax/driver/core/Connection.java b/driver-core/src/main/java/com/datastax/driver/core/Connection.java
@@ -115,12 +115,12 @@ protected Connection(String name, InetSocketAddress address, Factory factory) th
             try {
                 // Wait until the connection attempt succeeds or fails.
                 this.channel = future.awaitUninterruptibly().channel();
-                this.factory.allChannels.add(this.channel);
                 if (!future.isSuccess()) {
                     if (logger.isDebugEnabled())
                         logger.debug(String.format("%s Error connecting to %s%s", this, address, extractMessage(future.cause())));
                     throw defunct(new TransportException(address, "Cannot connect", future.cause()));
                 }
+                this.factory.allChannels.add(this.channel);
                 channel.closeFuture().addListener(new ChannelCloseListener());
             } finally {
                 writer.decrementAndGet();
