Skip to content

Commit 89232e7

Browse files
rgomezcasasrgomezcasas
authored
Update to php8 style (CodelyTV#210)
* Update to php8 style * Apply code style
1 parent 306d594 commit 89232e7

104 files changed

Lines changed: 1855 additions & 737 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎apps/backoffice/backend/src/Controller/Courses/CoursesGetController.php‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,8 @@
1414

1515
final class CoursesGetController
1616
{
17-
private $queryBus;
18-
19-
public function __construct(QueryBus $queryBus)
17+
public function __construct(private QueryBus $queryBus)
2018
{
21-
$this->queryBus = $queryBus;
2219
}
2320

2421
public function __invoke(Request $request): JsonResponse

‎apps/backoffice/backend/src/Controller/Metrics/MetricsController.php‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,8 @@
1111

1212
final class MetricsController
1313
{
14-
private PrometheusMonitor $monitor;
15-
16-
public function __construct(PrometheusMonitor $monitor)
14+
public function __construct(private PrometheusMonitor $monitor)
1715
{
18-
$this->monitor = $monitor;
1916
}
2017

2118
public function __invoke(Request $request): Response

‎apps/backoffice/frontend/src/Command/ImportCoursesToElasticsearchCommand.php‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,11 @@
1212

1313
final class ImportCoursesToElasticsearchCommand extends Command
1414
{
15-
private MySqlBackofficeCourseRepository $mySqlRepository;
16-
private ElasticsearchBackofficeCourseRepository $elasticRepository;
17-
1815
public function __construct(
19-
MySqlBackofficeCourseRepository $mySqlRepository,
20-
ElasticsearchBackofficeCourseRepository $elasticRepository
16+
private MySqlBackofficeCourseRepository $mySqlRepository,
17+
private ElasticsearchBackofficeCourseRepository $elasticRepository
2118
) {
2219
parent::__construct();
23-
24-
$this->mySqlRepository = $mySqlRepository;
25-
$this->elasticRepository = $elasticRepository;
2620
}
2721

2822
public function execute(InputInterface $input, OutputInterface $output): void

‎apps/backoffice/frontend/src/Controller/Courses/CoursesGetWebController.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@
1313

1414
final class CoursesGetWebController extends WebController
1515
{
16-
protected function exceptions(): array
17-
{
18-
return [];
19-
}
20-
2116
public function __invoke(Request $request): Response
2217
{
2318
/** @var CoursesCounterResponse $coursesCounterResponse */
@@ -33,4 +28,9 @@ public function __invoke(Request $request): Response
3328
]
3429
);
3530
}
31+
32+
protected function exceptions(): array
33+
{
34+
return [];
35+
}
3636
}

‎apps/backoffice/frontend/src/Controller/Courses/CoursesPostWebController.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,6 @@
1414

1515
final class CoursesPostWebController extends WebController
1616
{
17-
protected function exceptions(): array
18-
{
19-
return [];
20-
}
21-
2217
public function __invoke(Request $request): RedirectResponse
2318
{
2419
$validationErrors = $this->validateRequest($request);
@@ -28,6 +23,11 @@ public function __invoke(Request $request): RedirectResponse
2823
: $this->createCourse($request);
2924
}
3025

26+
protected function exceptions(): array
27+
{
28+
return [];
29+
}
30+
3131
private function validateRequest(Request $request): ConstraintViolationListInterface
3232
{
3333
$constraint = new Assert\Collection(

‎apps/backoffice/frontend/src/Controller/Home/HomeGetWebController.php‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,6 @@
1010

1111
final class HomeGetWebController extends WebController
1212
{
13-
protected function exceptions(): array
14-
{
15-
return [];
16-
}
17-
1813
public function __invoke(Request $request): Response
1914
{
2015
return $this->render(
@@ -25,4 +20,9 @@ public function __invoke(Request $request): Response
2520
]
2621
);
2722
}
23+
24+
protected function exceptions(): array
25+
{
26+
return [];
27+
}
2828
}

‎apps/backoffice/frontend/src/Controller/Metrics/MetricsController.php‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,8 @@
1111

1212
final class MetricsController
1313
{
14-
private PrometheusMonitor $monitor;
15-
16-
public function __construct(PrometheusMonitor $monitor)
14+
public function __construct(private PrometheusMonitor $monitor)
1715
{
18-
$this->monitor = $monitor;
1916
}
2017

2118
public function __invoke(Request $request): Response

‎apps/bootstrap.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
// Run "composer dump-env prod" to create it (requires symfony/flex >=1.2)
1111
if (is_array($env = @include $rootPath . '/.env.local.php')) {
1212
foreach ($env as $k => $v) {
13-
$_ENV[$k] = $_ENV[$k] ?? (isset($_SERVER[$k]) && 0 !== strpos($k, 'HTTP_') ? $_SERVER[$k] : $v);
13+
$_ENV[$k] = $_ENV[$k] ?? (isset($_SERVER[$k]) && str_starts_with($k, 'HTTP_') ? $_SERVER[$k] : $v);
1414
}
1515
} elseif (!class_exists(Dotenv::class)) {
1616
throw new RuntimeException(

‎apps/mooc/backend/src/Command/DomainEvents/MySql/ConsumeMySqlDomainEventsCommand.php‎

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,13 @@
1616

1717
final class ConsumeMySqlDomainEventsCommand extends Command
1818
{
19-
protected static $defaultName = 'codelytv:domain-events:mysql:consume';
20-
private MySqlDoctrineDomainEventsConsumer $consumer;
21-
private DomainEventSubscriberLocator $subscriberLocator;
22-
private DatabaseConnections $connections;
19+
protected static $defaultName = 'codelytv:domain-events:mysql:consume';
2320

2421
public function __construct(
25-
MySqlDoctrineDomainEventsConsumer $consumer,
26-
DatabaseConnections $connections,
27-
DomainEventSubscriberLocator $subscriberLocator
22+
private MySqlDoctrineDomainEventsConsumer $consumer,
23+
private DatabaseConnections $connections,
24+
private DomainEventSubscriberLocator $subscriberLocator
2825
) {
29-
$this->consumer = $consumer;
30-
$this->subscriberLocator = $subscriberLocator;
31-
$this->connections = $connections;
32-
3326
parent::__construct();
3427
}
3528

‎apps/mooc/backend/src/Command/DomainEvents/RabbitMq/ConfigureRabbitMqCommand.php‎

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,14 @@
1212

1313
final class ConfigureRabbitMqCommand extends Command
1414
{
15-
protected static $defaultName = 'codelytv:domain-events:rabbitmq:configure';
16-
private RabbitMqConfigurer $configurer;
17-
private string $exchangeName;
18-
private Traversable $subscribers;
15+
protected static $defaultName = 'codelytv:domain-events:rabbitmq:configure';
1916

20-
public function __construct(RabbitMqConfigurer $configurer, string $exchangeName, Traversable $subscribers)
21-
{
17+
public function __construct(
18+
private RabbitMqConfigurer $configurer,
19+
private string $exchangeName,
20+
private Traversable $subscribers
21+
) {
2222
parent::__construct();
23-
24-
$this->configurer = $configurer;
25-
$this->exchangeName = $exchangeName;
26-
$this->subscribers = $subscribers;
2723
}
2824

2925
protected function configure(): void

0 commit comments

Comments
 (0)