Skip to content

Commit 75829f0

Browse files
adchiaadchia
authored
ci: Fix setuptools issue with wildcard (feast-dev#3471)
* ci: Fix setuptools issue with wildcard Signed-off-by: Danny Chiao <danny@tecton.ai> * fix lint Signed-off-by: Danny Chiao <danny@tecton.ai> * pin mypy Signed-off-by: Danny Chiao <danny@tecton.ai> * fix httpx test Signed-off-by: Danny Chiao <danny@tecton.ai> * pin mypy Signed-off-by: Danny Chiao <danny@tecton.ai> * fix lint issue Signed-off-by: Danny Chiao <danny@tecton.ai> * final fix Signed-off-by: Danny Chiao <danny@tecton.ai> --------- Signed-off-by: Danny Chiao <danny@tecton.ai>
1 parent dfd5eae commit 75829f0

11 files changed

Lines changed: 546 additions & 444 deletions

‎Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ format-python:
289289
cd ${ROOT_DIR}/sdk/python; python -m isort feast/ tests/
290290

291291
# Format
292-
cd ${ROOT_DIR}/sdk/python; python -m black --target-version py37 feast tests
292+
cd ${ROOT_DIR}/sdk/python; python -m black --target-version py38 feast tests
293293

294294
lint-python:
295295
cd ${ROOT_DIR}/sdk/python; python -m mypy

‎sdk/python/feast/feature_store.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2327,7 +2327,7 @@ def serve_ui(
23272327
port: int,
23282328
get_registry_dump: Callable,
23292329
registry_ttl_sec: int,
2330-
root_path: Optional[str] = "",
2330+
root_path: str = "",
23312331
) -> None:
23322332
"""Start the UI server locally"""
23332333
if flags_helper.is_test():

‎sdk/python/feast/infra/materialization/contrib/spark/spark_materialization_engine.py‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from dataclasses import dataclass
22
from datetime import datetime
3-
from typing import Callable, List, Literal, Optional, Sequence, Union
3+
from typing import Callable, List, Literal, Optional, Sequence, Union, cast
44

55
import dill
66
import pandas as pd
@@ -154,7 +154,8 @@ def _materialize_one(
154154
job_id = f"{feature_view.name}-{start_date}-{end_date}"
155155

156156
try:
157-
offline_job: SparkRetrievalJob = (
157+
offline_job = cast(
158+
SparkRetrievalJob,
158159
self.offline_store.pull_latest_from_table_or_query(
159160
config=self.repo_config,
160161
data_source=feature_view.batch_source,
@@ -164,7 +165,7 @@ def _materialize_one(
164165
created_timestamp_column=created_timestamp_column,
165166
start_date=start_date,
166167
end_date=end_date,
167-
)
168+
),
168169
)
169170

170171
spark_serialized_artifacts = _SparkSerializedArtifacts.serialize(

‎sdk/python/feast/ui_server.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ def start_server(
101101
get_registry_dump: Callable,
102102
project_id: str,
103103
registry_ttl_sec: int,
104-
root_path: Optional[str] = "",
104+
root_path: str = "",
105105
):
106106
app = get_app(
107107
store,

0 commit comments

Comments
 (0)