Add debug logging and exception handling to DefaultMapperContext.locateResultProducers

adutra · adutra · commit dfb816e5f747 · 2021-05-25T18:11:15.000+02:00
diff --git a/mapper-runtime/src/main/java/com/datastax/oss/driver/internal/mapper/DefaultMapperContext.java b/mapper-runtime/src/main/java/com/datastax/oss/driver/internal/mapper/DefaultMapperContext.java
@@ -32,12 +32,17 @@
 import java.lang.reflect.InvocationTargetException;
 import java.util.Map;
 import java.util.Objects;
+import java.util.ServiceConfigurationError;
 import java.util.ServiceLoader;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ConcurrentMap;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class DefaultMapperContext implements MapperContext {
 
+  private static final Logger LOGGER = LoggerFactory.getLogger(DefaultMapperContext.class);
+
   private final ConcurrentMap<GenericType<?>, MapperResultProducer> resultProducerCache =
       new ConcurrentHashMap<>();
 
@@ -188,10 +193,20 @@ private static NameConverter buildNameConverter(Class<? extends NameConverter> c
 
   private static ImmutableList<MapperResultProducer> locateResultProducers(
       ClassLoader classLoader) {
-    ImmutableList.Builder<MapperResultProducer> result = ImmutableList.builder();
-    ServiceLoader<MapperResultProducerService> loader =
-        ServiceLoader.load(MapperResultProducerService.class, classLoader);
-    loader.iterator().forEachRemaining(provider -> result.addAll(provider.getProducers()));
-    return result.build();
+    LOGGER.debug(
+        "Locating result producers with CL = {}, MapperResultProducerService CL = {}",
+        classLoader,
+        MapperResultProducerService.class.getClassLoader());
+    ImmutableList.Builder<MapperResultProducer> builder = ImmutableList.builder();
+    try {
+      ServiceLoader<MapperResultProducerService> loader =
+          ServiceLoader.load(MapperResultProducerService.class, classLoader);
+      loader.iterator().forEachRemaining(provider -> builder.addAll(provider.getProducers()));
+    } catch (Exception | ServiceConfigurationError e) {
+      LOGGER.error("Failed to locate result producers", e);
+    }
+    ImmutableList<MapperResultProducer> producers = builder.build();
+    LOGGER.debug("Located {} result producers: {}", producers.size(), producers);
+    return producers;
   }
 }
