Protect against null datacenter

adutra · adutra · commit 426b4c738c0d · 2020-04-23T17:14:05.000+02:00
diff --git a/core/src/main/java/com/datastax/oss/driver/internal/core/metadata/diagnostic/topology/TopologyDiagnosticGenerator.java b/core/src/main/java/com/datastax/oss/driver/internal/core/metadata/diagnostic/topology/TopologyDiagnosticGenerator.java
@@ -69,22 +69,25 @@ protected void generateChildDiagnostics(
       DefaultNodeGroupDiagnostic.Builder globalDiagnostic,
       Map<String, DefaultNodeGroupDiagnostic.Builder> localDiagnostics) {
     for (Node node : nodes.values()) {
-      DefaultNodeGroupDiagnostic.Builder localDiagnostic =
-          localDiagnostics.compute(
-              node.getDatacenter(),
-              (dc, diag) -> diag == null ? new DefaultNodeGroupDiagnostic.Builder() : diag);
-      localDiagnostic.incrementTotal();
-      globalDiagnostic.incrementTotal();
-      if (node.getState() == NodeState.UP) {
-        localDiagnostic.incrementUp();
-        globalDiagnostic.incrementUp();
-      } else if (node.getState() == NodeState.UNKNOWN) {
-        localDiagnostic.incrementUnknown();
-        globalDiagnostic.incrementUnknown();
-      } else {
-        localDiagnostic.incrementDown();
-        globalDiagnostic.incrementDown();
+      if (node.getDatacenter() != null) {
+        DefaultNodeGroupDiagnostic.Builder localDiagnostic =
+            localDiagnostics.compute(
+                node.getDatacenter(),
+                (dc, diag) -> diag == null ? new DefaultNodeGroupDiagnostic.Builder() : diag);
+        incrementCounters(localDiagnostic, node);
       }
+      incrementCounters(globalDiagnostic, node);
+    }
+  }
+
+  protected void incrementCounters(DefaultNodeGroupDiagnostic.Builder diagnostic, Node node) {
+    diagnostic.incrementTotal();
+    if (node.getState() == NodeState.UP) {
+      diagnostic.incrementUp();
+    } else if (node.getState() == NodeState.UNKNOWN) {
+      diagnostic.incrementUnknown();
+    } else {
+      diagnostic.incrementDown();
     }
   }
 }
