Log query warnings before setting the final result

Alexandre Dutra · adutra · commit 29bb2806d11e · 2019-05-27T21:13:56.000+02:00
Motivation:

Currently the callback result is set _before_ the query warnings are
logged. As a consequence, client code dependent on the callback's
completion may get executed before the warnings are logged.

Modification:

Set the callback result after the query warnings are logged.

Result:

Client code is guaranteed to be executed after the query warnings are
logged.
diff --git a/driver-core/src/main/java/com/datastax/driver/core/RequestHandler.java b/driver-core/src/main/java/com/datastax/driver/core/RequestHandler.java
@@ -225,7 +225,6 @@ private void setFinalResult(
                 execution.retryConsistencyLevel,
                 response.getCustomPayload());
       }
-      callback.onSet(connection, response, info, statement, System.nanoTime() - startTime);
       // if the response from the server has warnings, they'll be set on the ExecutionInfo. Log them
       // here, unless they've been disabled.
       if (response.warnings != null
@@ -234,6 +233,7 @@ private void setFinalResult(
           && logger.isWarnEnabled()) {
         logServerWarnings(response.warnings);
       }
+      callback.onSet(connection, response, info, statement, System.nanoTime() - startTime);
     } catch (Exception e) {
       callback.onException(
           connection,
