Skip to content

Commit ce158ac

Browse files
committed
Filter out three false positives (the only warnings the trunk code base currently generates)
git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1504558 13f79535-47bb-0310-9956-ffa450edef68
1 parent b8572d7 commit ce158ac

1 file changed

Lines changed: 18 additions & 0 deletions

File tree

res/findbugs/filter-false-positives.xml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,12 @@
228228
<Method name="writeToSocket"/>
229229
<Bug code="UL" />
230230
</Match>
231+
<Match>
232+
<!-- Returning null is required by the EL specification -->
233+
<Class name="org.apache.el.lang.ELSupport" />
234+
<Method name="coerceToBoolean"/>
235+
<Bug pattern="NP_BOOLEAN_RETURN_NULL"/>
236+
</Match>
231237
<Match>
232238
<!-- JspC will not be used under a security manager -->
233239
<Class name="org.apache.jasper.JspC"/>
@@ -489,6 +495,12 @@
489495
</Match>
490496

491497
<!-- Test code -->
498+
<Match>
499+
<!-- Code is intentionally unused -->
500+
<Class name="org.apache.catalina.authenticator.TestBasicAuthParser"/>
501+
<Method name="testAuthMethodBadMethod"/>
502+
<Bug pattern="DLS_DEAD_LOCAL_STORE"/>
503+
</Match>
492504
<Match>
493505
<Class name="org.apache.catalina.core.TestApplicationSessionCookieConfig$CustomContext" />
494506
<Method name="getState"/>
@@ -607,6 +619,12 @@
607619
<Class name="org.apache.tomcat.jdbc.pool.interceptor.TestInterceptor" />
608620
<Bug code="ST" />
609621
</Match>
622+
<Match>
623+
<!-- Return value of latch is intentionally ignored -->
624+
<Class name="org.apache.tomcat.websocket.TestWebSocketFrameClient"/>
625+
<Method name="testConnectToServerEndpointSSL"/>
626+
<Bug pattern="RV_RETURN_VALUE_IGNORED"/>
627+
</Match>
610628
<Match>
611629
<Class name="org.apache.tomcat.util.net.TestSsl" />
612630
<Or>

0 commit comments

Comments
 (0)