[netty#4357] Fix possible assert error in GlobalEventExecutor

normanmaurer · normanmaurer · commit 4c8bc81505e4 · 2015-10-16T20:56:18.000+02:00
Motivation:

We started the thread before store it in a field which could lead to an assert error when the thread is executed before we actually store it.

Modifications:

Store thread before start it.

Result:

No more assert error possible.
diff --git a/common/src/main/java/io/netty/util/concurrent/GlobalEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/GlobalEventExecutor.java
@@ -214,8 +214,11 @@ public void execute(Runnable task) {
     private void startThread() {
         if (started.compareAndSet(false, true)) {
             Thread t = threadFactory.newThread(taskRunner);
-            t.start();
+            // Set the thread before starting it as otherwise inEventLoop() may return false and so produce
+            // an assert error.
+            // See https://github.com/netty/netty/issues/4357
             thread = t;
+            t.start();
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -214,8 +214,11 @@ public void execute(Runnable task) {`
`214`	`214`	`private void startThread() {`
`215`	`215`	`if (started.compareAndSet(false, true)) {`
`216`	`216`	`Thread t = threadFactory.newThread(taskRunner);`
`217`		`- t.start();`
	`217`	`+ // Set the thread before starting it as otherwise inEventLoop() may return false and so produce`
	`218`	`+ // an assert error.`
	`219`	`+ // See https://github.com/netty/netty/issues/4357`
`218`	`220`	`thread = t;`
	`221`	`+ t.start();`
`219`	`222`	`}`
`220`	`223`	`}`
`221`	`224`