Skip to content

Commit 11d43ce

Browse files
committed
DefaultPromiseTest dead code removal
Motivation: DefaultPromiseTest has dead code which was left over from a code restructure. Shared code between 2 tests was moved into a common method, but some code which was not cleaned up in each of these methods after the code was moved. Modifications: - Delete dead code in DefaultPromiseTest Result: Less dead code
1 parent ab43446 commit 11d43ce

1 file changed

Lines changed: 2 additions & 12 deletions

File tree

common/src/test/java/io/netty/util/concurrent/DefaultPromiseTest.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -178,22 +178,12 @@ public void testPromiseListenerAddWhenCompleteSuccess() throws Exception {
178178

179179
@Test(timeout = 2000)
180180
public void testLateListenerIsOrderedCorrectlySuccess() throws InterruptedException {
181-
final EventExecutor executor = new TestEventExecutor();
182-
try {
183-
testLateListenerIsOrderedCorrectly(null);
184-
} finally {
185-
executor.shutdownGracefully(0, 0, TimeUnit.SECONDS).sync();
186-
}
181+
testLateListenerIsOrderedCorrectly(null);
187182
}
188183

189184
@Test(timeout = 2000)
190185
public void testLateListenerIsOrderedCorrectlyFailure() throws InterruptedException {
191-
final EventExecutor executor = new TestEventExecutor();
192-
try {
193-
testLateListenerIsOrderedCorrectly(fakeException());
194-
} finally {
195-
executor.shutdownGracefully(0, 0, TimeUnit.SECONDS).sync();
196-
}
186+
testLateListenerIsOrderedCorrectly(fakeException());
197187
}
198188

199189
/**

0 commit comments

Comments
 (0)