fix an old misfeature: "BufferedLogs Off" would sort-of turn

trawick · trawick · commit e1a45dc5ad7e · 2004-02-26T20:15:26.000Z
buffered logging on as it set the log writer to the buffered log writer, though it would leave the are-logs-buffered flag off this misfeature combined with recent mutex logic for buffered logs led to a segfault with "BufferedLogs Off" git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@102783 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/modules/loggers/mod_log_config.c b/modules/loggers/mod_log_config.c
@@ -1041,8 +1041,10 @@ static const char *set_cookie_log(cmd_parms *cmd, void *dummy, const char *fn)
 static const char *set_buffered_logs_on(cmd_parms *parms, void *dummy, int flag)
 {
     buffered_logs = flag;
-    ap_log_set_writer_init(ap_buffered_log_writer_init);
-    ap_log_set_writer(ap_buffered_log_writer);
+    if (buffered_logs) {
+        ap_log_set_writer_init(ap_buffered_log_writer_init);
+        ap_log_set_writer(ap_buffered_log_writer);
+    }
     return NULL;
 }
 static const command_rec config_log_cmds[] =

Original file line number	Diff line number	Diff line change
`@@ -1041,8 +1041,10 @@ static const char set_cookie_log(cmd_parms cmd, void dummy, const char fn)`
`1041`	`1041`	`static const char set_buffered_logs_on(cmd_parms parms, void *dummy, int flag)`
`1042`	`1042`	`{`
`1043`	`1043`	`buffered_logs = flag;`
`1044`		`- ap_log_set_writer_init(ap_buffered_log_writer_init);`
`1045`		`- ap_log_set_writer(ap_buffered_log_writer);`
	`1044`	`+ if (buffered_logs) {`
	`1045`	`+ ap_log_set_writer_init(ap_buffered_log_writer_init);`
	`1046`	`+ ap_log_set_writer(ap_buffered_log_writer);`
	`1047`	`+ }`
`1046`	`1048`	`return NULL;`
`1047`	`1049`	`}`
`1048`	`1050`	`static const command_rec config_log_cmds[] =`