Do not cache responses to GET requests with query

Bill Stoddard · Bill Stoddard · commit c4411313dd8f · 2002-09-12T14:36:18.000Z
URLs if the origin server does not explicitly provide an Expires header on the response (RFC 2616 Section 13.9) Submitted by: Kris Verbeeck <krisv@be.ubizen.com> Reviewed by: Bill Stoddard git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@96772 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/CHANGES b/CHANGES
@@ -1,4 +1,8 @@
 Changes with Apache 2.0.41
+  *) mod_cache: Do not cache responses to GET requests with query
+     URLs if the origin server does not explicitly provide an
+     Expires header on the response (RFC 2616 Section 13.9)
+     [Kris Verbeeck krisv@be.ubizen.com]
 
   *) Fix memory leak in core_output_filter.  [Justin Erenkrantz]
 
diff --git a/modules/experimental/mod_cache.c b/modules/experimental/mod_cache.c
@@ -538,6 +538,10 @@ static int cache_in_filter(ap_filter_t *f, apr_bucket_brigade *in)
              && r->status != HTTP_NOT_MODIFIED)
             /* if a broken Expires header is present, don't cache it */
             || (exps != NULL && exp == APR_DATE_BAD)
+            /* if query string present but no expiration time, don't cache it
+             * (RFC 2616/13.9)
+             */
+            || (r->args && exps == NULL)
             /* if the server said 304 Not Modified but we have no cache
              * file - pass this untouched to the user agent, it's not for us.
              */
