Paul J. Reder · Paul J. Reder · commit be59c77cd7b6 · 2003-11-25T17:23:31.000Z
Merge this fix from 2.1-dev: *) mod_expires: Initialize ExpiresDefault to NULL instead of "" to avoid reporting an Internal Server error if it is used without having been set in the httpd.conf file. PR: 23748, 24459 Reviewed by: Andre Malo and Jeff Trawick. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/APACHE_2_0_BRANCH@101890 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/CHANGES b/CHANGES
@@ -1,5 +1,10 @@
 Changes with Apache 2.0.49
 
+  *) mod_expires: Initialize ExpiresDefault to NULL instead of "" to
+     avoid reporting an Internal Server error if it is used without
+     having been set in the httpd.conf file. PR: 23748, 24459
+     [Andre Malo, Liam Quinn  <liam htmlhelp.com>]
+
   *) mod_autoindex: Don't omit the <tr> start tag if the SuppressIcon
      option is set. PR 21668.  [Jesse Tie-Ten-Quee <highos highos.com>]
 
diff --git a/STATUS b/STATUS
@@ -1,5 +1,5 @@
 APACHE 2.0 STATUS:                                              -*-text-*-
-Last modified at [$Date: 2003/11/25 15:39:52 $]
+Last modified at [$Date: 2003/11/25 17:23:30 $]
 
 Release:
 
@@ -74,13 +74,6 @@ PATCHES TO BACKPORT FROM 2.1
   [ please place file names and revisions from HEAD here, so it is easy to
     identify exactly what the proposed changes are! ]
 
-    * mod_expires: Initialize ExpiresDefault to NULL instead of "" to
-      avoid reporting an Internal Server error if it is used without
-      having been set in the httpd.conf file. PR: 23748, 24459
-      http://cvs.apache.org/viewcvs.cgi/httpd-2.0/modules/metadata/mod_expires.c.diff?r1=1.46&r2=1.47
-      http://cvs.apache.org/viewcvs.cgi/httpd-2.0/modules/metadata/mod_expires.c.diff?r1=1.47&r2=1.48
-      +1: rederpj, nd, trawick
-
     * Make Win32 MPM honor MaxMemFree for transaction pools
       server/mpm/winnt/child.c: r1.17
       server/mpm/winnt/mpm.h: r1.14
diff --git a/modules/metadata/mod_expires.c b/modules/metadata/mod_expires.c
@@ -227,7 +227,7 @@ static void *create_dir_expires_config(apr_pool_t *p, char *dummy)
     expires_dir_config *new =
     (expires_dir_config *) apr_pcalloc(p, sizeof(expires_dir_config));
     new->active = ACTIVE_DONTCARE;
-    new->expiresdefault = "";
+    new->expiresdefault = NULL;
     new->expiresbytype = apr_table_make(p, 4);
     return (void *) new;
 }
@@ -404,7 +404,7 @@ static void *merge_expires_dir_configs(apr_pool_t *p, void *basev, void *addv)
         new->active = add->active;
     }
 
-    if (add->expiresdefault[0] != '\0') {
+    if (add->expiresdefault != NULL) {
         new->expiresdefault = add->expiresdefault;
     }
     else {

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,7 @@ static void create_dir_expires_config(apr_pool_t p, char *dummy)`
`227`	`227`	`expires_dir_config *new =`
`228`	`228`	`(expires_dir_config *) apr_pcalloc(p, sizeof(expires_dir_config));`
`229`	`229`	`new->active = ACTIVE_DONTCARE;`
`230`		`- new->expiresdefault = "";`
	`230`	`+ new->expiresdefault = NULL;`
`231`	`231`	`new->expiresbytype = apr_table_make(p, 4);`
`232`	`232`	`return (void *) new;`
`233`	`233`	`}`
`@@ -404,7 +404,7 @@ static void merge_expires_dir_configs(apr_pool_t p, void basev, void addv)`
`404`	`404`	`new->active = add->active;`
`405`	`405`	`}`
`406`	`406`
`407`		`- if (add->expiresdefault[0] != '\0') {`
	`407`	`+ if (add->expiresdefault != NULL) {`
`408`	`408`	`new->expiresdefault = add->expiresdefault;`
`409`	`409`	`}`
`410`	`410`	`else {`