Skip to content

Commit 96ffd29

Browse files
author
Cliff Woolley
committed
update a comment
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97616 13f79535-47bb-0310-9956-ffa450edef68
1 parent 1c976c0 commit 96ffd29

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

modules/cache/mod_file_cache.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -249,14 +249,12 @@ static void cache_the_file(cmd_parms *cmd, const char *filename, int mmap)
249249
return;
250250
}
251251
apr_file_close(fd);
252-
/* We want to cache an apr_mmap_t that's marked as "non-owner"
253-
* to pass to each request so that mmap_setaside()'s call to
254-
* apr_mmap_dup() will never try to move the apr_mmap_t to a
255-
* different pool. This apr_mmap_t is already going to live
256-
* longer than any request, but mmap_setaside() has no way to
257-
* know that because it's allocated out of cmd->pool,
258-
* which is disjoint from r->pool.
259-
*/
252+
/* We want to cache a duplicate apr_mmap_t to pass to each
253+
* request so that nothing in the request will ever think that
254+
* it's allowed to delete the mmap, since the "refcount" will
255+
* never reach zero. */
256+
/* XXX: the transfer_ownership flag on this call
257+
* will go away soon.. it's ignored right now. */
260258
apr_mmap_dup(&new_file->mm, mm, cmd->pool, 0);
261259
new_file->is_mmapped = TRUE;
262260
}

0 commit comments

Comments
 (0)