Resolve lint warnings

kgryte · kgryte · commit f03e84e88a8d · 2018-09-08T02:34:12.000-07:00
diff --git a/tools/scripts/update_contributors b/tools/scripts/update_contributors
@@ -39,7 +39,8 @@ this_script=$(perl -MFile::Spec -e 'print File::Spec->abs2rel(@ARGV)' "$0" "${ro
 
 # Lists contributors.
 list_contributors() {
-	local contributors="$(git shortlog -sne | cut -f 2 | sort)"
+	local contributors
+	contributors="$(git shortlog -sne | cut -f 2 | sort)"
 	echo "${contributors}"
 }
 
diff --git a/tools/test-cov/scripts/coverage_report_name b/tools/test-cov/scripts/coverage_report_name
@@ -48,7 +48,7 @@ main() {
 	path="${testdir#${base}/}"
 
 	# Slugify the path (basic algorithm):
-	slug="$(echo ${path} | sed -e 's/[^[:alnum:]]/_/g' | tr -s '-' | tr A-Z a-z)"
+	slug=$(echo "${path}" | sed -e 's/[^[:alnum:]]/_/g' | tr -s '-' | tr '[:upper:]' '[:lower:]')
 
 	# Generate a filename:
 	echo "${output}/coverage${slug}.json"

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,8 @@ this_script=$(perl -MFile::Spec -e 'print File::Spec->abs2rel(@ARGV)' "$0" "${ro`
`39`	`39`
`40`	`40`	`# Lists contributors.`
`41`	`41`	`list_contributors() {`
`42`		`- local contributors="$(git shortlog -sne \| cut -f 2 \| sort)"`
	`42`	`+ local contributors`
	`43`	`+ contributors="$(git shortlog -sne \| cut -f 2 \| sort)"`
`43`	`44`	`echo "${contributors}"`
`44`	`45`	`}`
`45`	`46`