Fix rest pattern completion

kgryte · kgryte · commit ec7c71447633 · 2019-04-11T16:19:58.000-07:00
diff --git a/lib/node_modules/@stdlib/repl/ctor/lib/complete_resolve_local_scopes.js b/lib/node_modules/@stdlib/repl/ctor/lib/complete_resolve_local_scopes.js
@@ -78,10 +78,10 @@ function declarationPattern( node, parent ) {
 		appendUnique( parent.locals, node.name );
 		break;
 
-	// `var { a, b } = { 'a': 10, 'b': 20 }`
+	// `var { a, b } = { 'a': 10, 'b': 20 }` || `var { ...o } = {}`
 	case 'ObjectPattern':
 		for ( i = 0; i < node.properties.length; i++ ) {
-			declarationPattern( node.properties[ i ].value, parent );
+			declarationPattern( node.properties[ i ].value || node.properties[ i ].argument, parent ); // eslint-disable-line max-len
 		}
 		break;
 
@@ -94,7 +94,7 @@ function declarationPattern( node, parent ) {
 		}
 		break;
 
-	// `var [ x, y, ...z ] = [ 10, 20, 30, 40, 50 ]`
+	// `var [ x, y, ...z ] = [ 10, 20, 30, 40, 50 ]` || `var [ ...z ] = []`
 	case 'RestElement':
 		declarationPattern( node.argument, parent );
 		break;
@@ -161,7 +161,9 @@ function FunctionDeclaration( node, parents ) {
 		}
 	}
 	parent.locals = parent.locals || [];
-	appendUnique( parent.locals, node.id.name );
+	if ( node.id ) {
+		appendUnique( parent.locals, node.id.name );
+	}
 	declareFunction( node );
 }
 
@@ -182,7 +184,9 @@ function ClassDeclaration( node, parents ) {
 		}
 	}
 	parent.locals = parent.locals || [];
-	appendUnique( parent.locals, node.id.name );
+	if ( node.id ) {
+		appendUnique( parent.locals, node.id.name );
+	}
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -78,10 +78,10 @@ function declarationPattern( node, parent ) {`
`78`	`78`	`appendUnique( parent.locals, node.name );`
`79`	`79`	`break;`
`80`	`80`
`81`		- // `var { a, b } = { 'a': 10, 'b': 20 }`
	`81`	+ // `var { a, b } = { 'a': 10, 'b': 20 }` \|\| `var { ...o } = {}`
`82`	`82`	`case 'ObjectPattern':`
`83`	`83`	`for ( i = 0; i < node.properties.length; i++ ) {`
`84`		`- declarationPattern( node.properties[ i ].value, parent );`
	`84`	`+ declarationPattern( node.properties[ i ].value \|\| node.properties[ i ].argument, parent ); // eslint-disable-line max-len`
`85`	`85`	`}`
`86`	`86`	`break;`
`87`	`87`
`@@ -94,7 +94,7 @@ function declarationPattern( node, parent ) {`
`94`	`94`	`}`
`95`	`95`	`break;`
`96`	`96`
`97`		- // `var [ x, y, ...z ] = [ 10, 20, 30, 40, 50 ]`
	`97`	+ // `var [ x, y, ...z ] = [ 10, 20, 30, 40, 50 ]` \|\| `var [ ...z ] = []`
`98`	`98`	`case 'RestElement':`
`99`	`99`	`declarationPattern( node.argument, parent );`
`100`	`100`	`break;`
`@@ -161,7 +161,9 @@ function FunctionDeclaration( node, parents ) {`
`161`	`161`	`}`
`162`	`162`	`}`
`163`	`163`	`parent.locals = parent.locals \|\| [];`
`164`		`- appendUnique( parent.locals, node.id.name );`
	`164`	`+ if ( node.id ) {`
	`165`	`+ appendUnique( parent.locals, node.id.name );`
	`166`	`+ }`
`165`	`167`	`declareFunction( node );`
`166`	`168`	`}`
`167`	`169`
`@@ -182,7 +184,9 @@ function ClassDeclaration( node, parents ) {`
`182`	`184`	`}`
`183`	`185`	`}`
`184`	`186`	`parent.locals = parent.locals \|\| [];`
`185`		`- appendUnique( parent.locals, node.id.name );`
	`187`	`+ if ( node.id ) {`
	`188`	`+ appendUnique( parent.locals, node.id.name );`
	`189`	`+ }`
`186`	`190`	`}`
`187`	`191`
`188`	`192`	`/**`