Skip to content

Commit e599d17

Browse files
PlaneshifterPlaneshifter
committed
Upgrade to eslint v8
1 parent 8249695 commit e599d17

4 files changed

Lines changed: 38 additions & 60 deletions

File tree

‎etc/eslint/.eslintignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ reports/
2929
# Node.js #
3030
###########
3131
/node_modules/
32+
!/**/node_modules/*
3233

3334
# Git #
3435
#######

‎etc/eslint/plugins/index.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
// ESLint plugins:
2222
var plugins = [
23+
'node',
2324
'stdlib'
2425
];
2526

‎etc/eslint/rules/nodejs.js‎

Lines changed: 34 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ var rules = {};
2828
/**
2929
* Warn when a callback may be unintentionally called multiple times.
3030
*
31-
* @name callback-return
31+
* @name node/callback-return
3232
* @memberof rules
3333
* @type {Array}
34-
* @see [callback-return]{@link http://eslint.org/docs/rules/callback-return}
34+
* @see [node/callback-return]{@link https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/callback-return.md}
3535
*
3636
* @example
3737
* // Bad...
@@ -51,7 +51,7 @@ var rules = {};
5151
* clbk();
5252
* }
5353
*/
54-
rules[ 'callback-return' ] = [ 'warn', [
54+
rules[ 'node/callback-return' ] = [ 'warn', [
5555
'callback',
5656
'clbk',
5757
'cb',
@@ -62,11 +62,11 @@ rules[ 'callback-return' ] = [ 'warn', [
6262
/**
6363
* Allow `require` to be used in a nested scope.
6464
*
65-
* @name global-require
65+
* @name node/global-require
6666
* @memberof rules
6767
* @type {string}
6868
* @default 'off'
69-
* @see [global-require]{@link http://eslint.org/docs/rules/global-require}
69+
* @see [node/global-require]{@link https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/global-require.md}
7070
*
7171
* @example
7272
* // Okay...
@@ -77,16 +77,16 @@ rules[ 'callback-return' ] = [ 'warn', [
7777
* f = require( 'bar' );
7878
* }
7979
*/
80-
rules[ 'global-require' ] = 'off';
80+
rules[ 'node/global-require' ] = 'off';
8181

8282
/**
8383
* Always handle callback error arguments.
8484
*
85-
* @name handle-callback-err
85+
* @name node/handle-callback-err
8686
* @memberof rules
8787
* @type {Array}
8888
* @default [ 'error', '^(err|error)$' ]
89-
* @see [handle-callback-err]{@link http://eslint.org/docs/rules/handle-callback-err}
89+
* @see [node/handle-callback-err]{@link https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/handle-callback-err.md}
9090
*
9191
* @example
9292
* // Bad...
@@ -103,34 +103,15 @@ rules[ 'global-require' ] = 'off';
103103
* return clbk();
104104
* }
105105
*/
106-
rules[ 'handle-callback-err' ] = [ 'error', '^(err|error)$' ];
107-
108-
/**
109-
* Warn when using the `Buffer` constructor.
110-
*
111-
* @name no-buffer-constructor
112-
* @memberof rules
113-
* @type {string}
114-
* @default 'warn'
115-
* @see [no-buffer-constructor]{@link http://eslint.org/docs/rules/no-buffer-constructor}
116-
*
117-
* @example
118-
* // Bad...
119-
* var buf = new Buffer( [ 1, 2, 3 ] );
120-
*
121-
* @example
122-
* // Good...
123-
* var buf = Buffer.from( [ 1, 2, 3 ] );
124-
*/
125-
rules[ 'no-buffer-constructor' ] = 'warn'; // TODO: revisit once all Buffer usage includes support for older Node versions
106+
rules[ 'node/handle-callback-err' ] = [ 'error', '^(err|error)$' ];
126107

127108
/**
128109
* Only allow `require`d modules to be grouped together.
129110
*
130-
* @name no-mixed-requires
111+
* @name node/no-mixed-requires
131112
* @memberof rules
132113
* @type {Array}
133-
* @see [no-mixed-requires]{@link http://eslint.org/docs/rules/no-mixed-requires}
114+
* @see [node/no-mixed-requires]{@link https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-mixed-requires.md}
134115
*
135116
* @example
136117
* // Good...
@@ -139,19 +120,19 @@ rules[ 'no-buffer-constructor' ] = 'warn'; // TODO: revisit once all Buffer usag
139120
* var beep = require( '@stdlib/beep' );
140121
* var bar = require( './bar.js' );
141122
*/
142-
rules[ 'no-mixed-requires' ] = [ 'error', {
123+
rules[ 'node/no-mixed-requires' ] = [ 'error', {
143124
'grouping': false,
144125
'allowCall': true
145126
}];
146127

147128
/**
148129
* Never allow the use of `new require()`.
149130
*
150-
* @name no-new-require
131+
* @name node/no-new-require
151132
* @memberof rules
152133
* @type {string}
153134
* @default 'error'
154-
* @see [no-new-require]{@link http://eslint.org/docs/rules/no-new-require}
135+
* @see [node/no-new-require]{@link https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-new-require.md}
155136
*
156137
* @example
157138
* // Bad...
@@ -163,16 +144,16 @@ rules[ 'no-mixed-requires' ] = [ 'error', {
163144
*
164145
* var foo = new Foo();
165146
*/
166-
rules[ 'no-new-require' ] = 'error';
147+
rules[ 'node/no-new-require' ] = 'error';
167148

168149
/**
169150
* Never allow naive directory and file path concatenation.
170151
*
171-
* @name no-path-concat
152+
* @name node/no-path-concat
172153
* @memberof rules
173154
* @type {string}
174155
* @default 'error'
175-
* @see [no-path-concat]{@link http://eslint.org/docs/rules/no-path-concat}
156+
* @see [node/no-path-concat]{@link https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-path-concat.mdt}
176157
*
177158
* @example
178159
* // Bad...
@@ -183,60 +164,54 @@ rules[ 'no-new-require' ] = 'error';
183164
* var join = require( 'path' ).join;
184165
* var foo = require( join( __dirname, 'foo.js' ) );
185166
*/
186-
rules[ 'no-path-concat' ] = 'error';
167+
rules[ 'node/no-path-concat' ] = 'error';
187168

188169
/**
189170
* Discourage use of `process.env()`. Use `@stdlib` package instead.
190171
*
191-
* @name no-process-env
172+
* @name node/no-process-env
192173
* @memberof rules
193174
* @type {string}
194175
* @default 'error'
195-
* @see [no-process-env]{@link http://eslint.org/docs/rules/no-process-env}
176+
* @see [node/no-process-env]{@link https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-process-env.md}
196177
*/
197-
rules[ 'no-process-env' ] = 'error';
178+
rules[ 'node/no-process-env' ] = 'error';
198179

199180
/**
200181
* Warn when using `process.exit()`.
201182
*
202-
* @name no-process-exit
183+
* @name node/no-process-exit
203184
* @memberof rules
204185
* @type {string}
205186
* @default 'warn'
206-
* @see [no-process-exit]{@link http://eslint.org/docs/rules/no-process-exit}
187+
* @see [node/no-process-exit]{@link https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-process-exit.md}
207188
*/
208-
rules[ 'no-process-exit' ] = 'warn';
189+
rules[ 'node/no-process-exit' ] = 'warn';
209190

210191
/**
211192
* Restrict the use of specific modules.
212193
*
213-
* @name no-restricted-modules
194+
* @name node/no-restricted-require
214195
* @memberof rules
215196
* @type {Array}
216-
* @see [no-restricted-modules]{@link http://eslint.org/docs/rules/no-restricted-modules}
197+
* @see [node/no-restricted-require]{@link https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-restricted-require.md}
217198
*/
218-
rules[ 'no-restricted-modules' ] = [ 'error', {
219-
'paths': [
220-
'underscore',
221-
'lodash',
222-
'async'
223-
],
224-
'patterns': [
225-
'lodash*',
226-
'async/*'
227-
]
228-
}];
199+
rules[ 'node/no-restricted-require' ] = [ 'error', [
200+
'underscore',
201+
'lodash',
202+
'async'
203+
]];
229204

230205
/**
231206
* Warn when using synchronous methods when an asynchronous version exists.
232207
*
233-
* @name no-sync
208+
* @name node/no-sync
234209
* @memberof rules
235210
* @type {string}
236211
* @default 'warn'
237-
* @see [no-sync]{@link http://eslint.org/docs/rules/no-sync}
212+
* @see [node/no-sync]{@link https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-sync.md}
238213
*/
239-
rules[ 'no-sync' ] = 'warn';
214+
rules[ 'node/no-sync' ] = 'warn';
240215

241216

242217
// EXPORTS //

‎package.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,8 @@
118118
"doctrine": "^3.0.0",
119119
"dtslint": "^3.3.0",
120120
"envify": "^4.0.0",
121-
"eslint": "^6.4.0",
121+
"eslint": "^8.0.1",
122+
"eslint-plugin-node": "^11.1.0",
122123
"factor-bundle": "^2.5.0",
123124
"gh-pages": "^3.2.3",
124125
"istanbul": "^0.4.1",

0 commit comments

Comments
 (0)