fix: address dimension reduction bug

kgryte · kgryte · commit e17e1999c8d3 · 2023-09-23T19:52:12.000-07:00
diff --git a/lib/node_modules/@stdlib/ndarray/fancy/examples/3d.js b/lib/node_modules/@stdlib/ndarray/fancy/examples/3d.js
@@ -72,24 +72,24 @@ var s = E( 1, S(0,_,2), _ );
 // Use the slice to create a view on the original ndarray:
 var y1 = x[ s ];
 console.log( toArray( y1 ) );
-// => [ [ [ 9, 10 ], [ 13, 100 ] ] ]
+// => [ [ 9, 10 ], [ 13, 100 ] ]
 
 // Use alternative syntax:
 var y2 = x[ [ 1, S(0,_,2), _ ] ];
 console.log( toArray( y2 ) );
-// => [ [ [ 9, 10 ], [ 13, 100 ] ] ]
+// => [ [ 9, 10 ], [ 13, 100 ] ]
 
 // Use alternative syntax:
 var y3 = x[ '1,0::2,:' ];
 console.log( toArray( y3 ) );
-// => [ [ [ 9, 10 ], [ 13, 100 ] ] ]
+// => [ [ 9, 10 ], [ 13, 100 ] ]
 
 // Flip dimensions:
 var y4 = x[ [ 1, S(_,_,-2), S(_,_,-1) ] ];
 console.log( toArray( y4 ) );
-// => [ [ [ 100, 13 ], [ 10, 9 ] ] ]
+// => [ [ 100, 13 ], [ 10, 9 ] ]
 
 // Only the second rows:
 var y5 = x[ [ _, 1, _ ] ];
 console.log( toArray( y5 ) );
-// => [ [ [ 5, 6 ] ], [ [ 11, 12 ] ] ]
+// throws [ [ 5, 6 ], [ 11, 12 ] ]
diff --git a/lib/node_modules/@stdlib/ndarray/fancy/lib/view.nd.js b/lib/node_modules/@stdlib/ndarray/fancy/lib/view.nd.js
@@ -21,12 +21,12 @@
 // MODULES //
 
 var normalizeMultiSlice = require( '@stdlib/slice/base/normalize-multi-slice' );
+var nonreducedDimensions = require( '@stdlib/slice/base/nonreduced-dimensions' );
 var sliceShape = require( '@stdlib/slice/base/shape' );
 var take = require( '@stdlib/array/base/take' );
 var vind2bind = require( '@stdlib/ndarray/base/vind2bind' );
 var numel = require( '@stdlib/ndarray/base/numel' );
 var format = require( '@stdlib/string/format' );
-var nonreducedDimensions = require( '@stdlib/slice/base/nonreduced-dimensions' );
 var sliceStart = require( './slice_start.js' );
 var sliceStrides = require( './slice_strides.js' );
 var options = require( './array_options.js' );
@@ -58,6 +58,7 @@ function sliceView( target, property, receiver, slice ) {
 	var sdims;
 	var ctor;
 	var sh;
+	var ns;
 
 	// Verify that we were successfully able to create a multi-slice:
 	if ( slice === null ) {
@@ -76,17 +77,17 @@ function sliceView( target, property, receiver, slice ) {
 		throw new RangeError( format( 'invalid operation. Number of array dimensions does not match the number of slice dimensions. Array shape: (%s). Slice dimensions: %u.', shape.join( ',' ), slice.ndims ) );
 	}
 	// Normalize the slice object based on the array shape:
-	slice = normalizeMultiSlice( slice, shape, true );
+	ns = normalizeMultiSlice( slice, shape, true );
 
 	// In strict mode, if the slice exceeds array bounds, raise an exception...
-	if ( slice.code && strict ) {
+	if ( ns.code && strict ) {
 		throw new RangeError( format( 'invalid operation. Slice exceeds array bounds. Array shape: (%s).', shape.join( ',' ) ) );
 	}
 	// Resolve the output array constructor:
 	ctor = receiver.constructor;
 
 	// Compute the slice shape:
-	sh = sliceShape( slice );
+	sh = sliceShape( ns );
 
 	// Resolve the indices of the non-reduced dimensions:
 	sdims = nonreducedDimensions( slice );
@@ -96,7 +97,7 @@ function sliceView( target, property, receiver, slice ) {
 		return empty( ctor, dtype, take( sh, sdims ), order );
 	}
 	// Resolve the index offset of the first element:
-	offset = vind2bind( shape, strides, offset, order, sliceStart( slice, shape, strides, 0 ), 'throw' );
+	offset = vind2bind( shape, strides, offset, order, sliceStart( ns, shape, strides, 0 ), 'throw' );
 
 	// Remove reduced dimensions from the slice shape:
 	sh = take( sh, sdims );
@@ -106,7 +107,7 @@ function sliceView( target, property, receiver, slice ) {
 		return new ctor( dtype, target.data, [], [ 0 ], offset, order, options() ); // eslint-disable-line max-len
 	}
 	// Update strides according to slice steps:
-	strides = sliceStrides( slice, strides, sdims );
+	strides = sliceStrides( ns, strides, sdims );
 
 	// Return a slice view:
 	return new ctor( dtype, target.data, sh, strides, offset, order, options() ); // eslint-disable-line max-len
