Use Object.prototype.toString to resolve internal class

kgryte · kgryte · commit addc2d74a1d1 · 2021-08-21T14:13:13.000-07:00
Resolves stdlib-js#375.
diff --git a/lib/node_modules/@stdlib/assert/is-node/lib/main.js b/lib/node_modules/@stdlib/assert/is-node/lib/main.js
@@ -25,6 +25,7 @@ var getGlobal = require( '@stdlib/utils/global' );
 var nativeClass = require( '@stdlib/utils/native-class' );
 var isObject = require( '@stdlib/assert/is-plain-object' );
 var isString = require( '@stdlib/assert/is-string' ).isPrimitive;
+var toStr = require( './to_string.js' );
 var globalScope = require( './global_scope.js' );
 
 
@@ -74,14 +75,8 @@ function isNode() {
 		// Check for a `process` global variable:
 		typeof proc === 'object' &&
 
-		// Check that the `process` global variable has the expected internal class:
-		(
-			// Node < v14.6.0
-			nativeClass( proc ) === '[object process]' ||
-
-			// Node >= v14.6.0
-			nativeClass( proc ) === '[object Object]'
-		) &&
+		// Check that the `process` global variable has the expected internal class (NOTE: we use `toStr`, rather than `nativecClass` to address changes introduced in Node >= v14.6.0; see https://github.com/stdlib-js/stdlib/issues/375):
+		toStr( proc ) === '[object process]' &&
 
 		// Check for a `versions` property:
 		isObject( proc.versions ) &&
diff --git a/lib/node_modules/@stdlib/assert/is-node/lib/to_string.js b/lib/node_modules/@stdlib/assert/is-node/lib/to_string.js
@@ -0,0 +1,42 @@
+/**
+* @license Apache-2.0
+*
+* Copyright (c) 2021 The Stdlib Authors.
+*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+*    http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+'use strict';
+
+// VARIABLES //
+
+var toStr = Object.prototype.toString;
+
+
+// MAIN //
+
+/**
+* Returns the internal class of a provided value.
+*
+* @private
+* @param {*} value - input value
+* @returns {string} internal class
+*/
+function toString( value ) { // eslint-disable-line stdlib/no-redeclare
+	return toStr.call( value );
+}
+
+
+// EXPORTS //
+
+module.exports = toString;
diff --git a/lib/node_modules/@stdlib/assert/is-node/test/test.main.js b/lib/node_modules/@stdlib/assert/is-node/test/test.main.js
@@ -128,10 +128,7 @@ tape( 'the function returns `false` if runtime is not Node.js (`global` variable
 tape( 'the function returns `false` if runtime is not Node.js (`global` variable has wrong class)', function test( t ) {
 	var isNode;
 
-	function nativeClass( val ) {
-		if ( val === proc ) {
-			return '[object process]';
-		}
+	function nativeClass() {
 		return '[object beeeeeeep]';
 	}
 
@@ -183,12 +180,16 @@ tape( 'the function returns `false` if runtime is not Node.js (`global` variable
 tape( 'the function returns `false` if runtime is not Node.js (`process` variable has wrong class)', function test( t ) {
 	var isNode;
 
-	function nativeClass( val ) {
+	function nativeClass() {
+		// Node.js version <7 (https://github.com/nodejs/node/issues/9274):
+		return '[object global]';
+	}
+
+	function toStr( val ) {
 		if ( val === proc ) {
 			return '[object beeeeeeep]';
 		}
-		// Node.js version <7 (https://github.com/nodejs/node/issues/9274):
-		return '[object global]';
+		return Object.prototype.toString.call( val );
 	}
 
 	function isString() {}
@@ -202,7 +203,8 @@ tape( 'the function returns `false` if runtime is not Node.js (`process` variabl
 		'@stdlib/utils/native-class': nativeClass,
 		'@stdlib/assert/is-plain-object': alwaysTrue,
 		'@stdlib/assert/is-string': isString,
-		'./global_scope.js': true
+		'./global_scope.js': true,
+		'./to_string.js': toStr
 	});
 	t.equal( isNode(), false, 'returns false' );
 	t.end();
