Change arguments check and add explanatory note

kgryte · kgryte · commit 7464f4a60dc6 · 2016-06-18T11:20:07.000-07:00
diff --git a/tools/remark/plugins/remark-html-equation-src-urls/lib/attacher.js b/tools/remark/plugins/remark-html-equation-src-urls/lib/attacher.js
@@ -23,7 +23,9 @@ var defaults = require( './defaults.json' );
 */
 function attacher( remark, options ) {
 	var opts = copy( defaults );
-	if ( arguments.length > 1 ) {
+
+	// NOTE: cannot use `arguments.length` check, as `options` may be explicitly passed as `undefined`
+	if ( options !== void 0 ) {
 		if ( !isObject( options ) ) {
 			throw new TypeError( 'invalid input argument. Options argument must be an object. Value: `' + options + '`.' );
 		}
diff --git a/tools/remark/plugins/remark-svg-equations/lib/attacher.js b/tools/remark/plugins/remark-svg-equations/lib/attacher.js
@@ -23,7 +23,9 @@ var defaults = require( './defaults.json' );
 */
 function attacher( remark, options ) {
 	var opts = copy( defaults );
-	if ( options !== undefined ) {
+
+	// NOTE: cannot use `arguments.length` check, as `options` may be explicitly passed as `undefined`
+	if ( options !== void 0 ) {
 		if ( !isObject( options ) ) {
 			throw new TypeError( 'invalid input argument. Options argument must be an object. Value: `' + options + '`.' );
 		}
