Refactor to ignore iterator return values

kgryte · kgryte · commit 73f7279a2002 · 2021-12-16T00:50:16.000-08:00
diff --git a/lib/node_modules/@stdlib/iter/strided/lib/main.js b/lib/node_modules/@stdlib/iter/strided/lib/main.js
@@ -26,7 +26,6 @@ var isPositiveInteger = require( '@stdlib/assert/is-positive-integer' );
 var isBoolean = require( '@stdlib/assert/is-boolean' ).isPrimitive;
 var isFunction = require( '@stdlib/assert/is-function' );
 var isIteratorLike = require( '@stdlib/assert/is-iterator-like' );
-var hasOwnProp = require( '@stdlib/assert/has-own-property' );
 var iteratorSymbol = require( '@stdlib/symbol/iterator' );
 
 
@@ -74,6 +73,7 @@ function iterStrided( iterator, stride, offset, eager ) {
 	var bool;
 	var FLG;
 	var idx;
+	var ret;
 	var o;
 	var v;
 	var i;
@@ -107,6 +107,7 @@ function iterStrided( iterator, stride, offset, eager ) {
 			v = iterator.next();
 			if ( v.done ) {
 				FLG = true;
+				ret = v;
 				break;
 			}
 		}
@@ -134,9 +135,13 @@ function iterStrided( iterator, stride, offset, eager ) {
 	* @returns {Object} iterator protocol-compliant object
 	*/
 	function next() {
-		var out;
 		var v;
 		if ( FLG ) {
+			if ( ret ) {
+				v = ret;
+				ret = null;
+				return v;
+			}
 			return {
 				'done': true
 			};
@@ -146,27 +151,16 @@ function iterStrided( iterator, stride, offset, eager ) {
 			v = iterator.next();
 			if ( v.done ) {
 				FLG = true;
-				return {
-					'done': true
-				};
+				return v;
 			}
 			i += 1;
 		}
 		idx += stride;
 		v = iterator.next();
 		if ( v.done ) {
 			FLG = true;
-			out = {};
-			if ( hasOwnProp( v, 'value' ) ) {
-				out.value = v.value;
-			}
-			out.done = true;
-			return out;
 		}
-		return {
-			'value': v.value,
-			'done': false
-		};
+		return v;
 	}
 
 	/**
diff --git a/lib/node_modules/@stdlib/iter/strided/test/test.js b/lib/node_modules/@stdlib/iter/strided/test/test.js
@@ -28,37 +28,6 @@ var iteratorSymbol = require( '@stdlib/symbol/iterator' );
 var iterStrided = require( './../lib' );
 
 
-// FUNCTIONS //
-
-function createIterator( arr ) {
-	var len;
-	var it;
-	var i;
-
-	len = arr.length;
-	i = -1;
-
-	it = {};
-	it.next = next;
-
-	return it;
-
-	function next() {
-		var out;
-		i += 1;
-		if ( i < len ) {
-			out = {};
-			out.value = arr[ i ];
-			out.done = ( i === len-1 );
-			return out;
-		}
-		return {
-			'done': true
-		};
-	}
-}
-
-
 // TESTS //
 
 tape( 'main export is a function', function test( t ) {
@@ -350,44 +319,6 @@ tape( 'the function returns an iterator protocol-compliant object', function tes
 	t.end();
 });
 
-tape( 'the function returns an iterator protocol-compliant object (value+done)', function test( t ) {
-	var expected;
-	var values;
-	var actual;
-	var it;
-	var i;
-
-	values = [ 1, 2, 3, 4 ];
-	expected = [
-		{
-			'value': 1,
-			'done': false
-		},
-		{
-			'value': 2,
-			'done': false
-		},
-		{
-			'value': 3,
-			'done': false
-		},
-		{
-			'value': 4,
-			'done': true
-		}
-	];
-
-	it = iterStrided( createIterator( values ), 1 );
-	t.equal( it.next.length, 0, 'has zero arity' );
-
-	actual = [];
-	for ( i = 0; i < values.length; i++ ) {
-		actual.push( it.next() );
-	}
-	t.deepEqual( actual, expected, 'returns expected values' );
-	t.end();
-});
-
 tape( 'the function returns an iterator protocol-compliant object which steps by a specified amount', function test( t ) {
 	var expected;
 	var values;
