Update type and use logic to internal functions for IC

kgryte · kgryte · commit 6ad93089c234 · 2021-10-22T12:13:59.000-07:00
diff --git a/lib/node_modules/@stdlib/array/filled/docs/repl.txt b/lib/node_modules/@stdlib/array/filled/docs/repl.txt
@@ -97,7 +97,7 @@
     value: any
         Fill value.
 
-    iterable: Object
+    iterable: Iterable
         Iterable from which to generate an array.
 
     dtype: string (optional)
diff --git a/lib/node_modules/@stdlib/array/filled/lib/main.js b/lib/node_modules/@stdlib/array/filled/lib/main.js
@@ -38,18 +38,66 @@ var ITERATOR_SYMBOL = require( '@stdlib/symbol/iterator' );
 var HAS_ITERATOR_SYMBOL = hasIteratorSymbolSupport();
 
 
+// FUNCTIONS //
+
+/**
+* Creates a filled "generic" array.
+*
+* @private
+* @param {NonNegativeInteger} len - array length
+* @param {*} value - fill value
+* @returns {Array} filled array
+*/
+function filled( len, value ) {
+	var arr;
+	var i;
+
+	// Manually push elements in order to ensure "fast" elements...
+	arr = [];
+	for ( i = 0; i < len; i++ ) {
+		arr.push( value );
+	}
+	return arr;
+}
+
+/**
+* Creates a filled "generic" array from an iterator.
+*
+* @private
+* @param {Iterator} it - iterator
+* @param {*} value - fill value
+* @returns {Array} filled array
+*/
+function filledIterator( it, value ) {
+	var arr;
+	var v;
+
+	arr = [];
+	while ( true ) {
+		v = it.next();
+		if ( hasOwnProp( v, 'value' ) ) {
+			arr.push( value );
+		}
+		if ( v.done ) {
+			break;
+		}
+	}
+	return arr;
+}
+
+
 // MAIN //
 
 /**
 * Creates a filled array.
 *
 * @param {*} [value] - fill value
-* @param {(NonNegativeInteger|TypedArray|ArrayLikeObject|ArrayBuffer)} [arg] - a length, typed array, array-like object, or buffer
+* @param {(NonNegativeInteger|TypedArray|ArrayLikeObject|ArrayBuffer|Iterable)} [arg] - a length, typed array, array-like object, buffer, or iterable
 * @param {NonNegativeInteger} [byteOffset=0] - byte offset
 * @param {NonNegativeInteger} [length] - view length
 * @param {string} [dtype="float64"] - data type
 * @throws {TypeError} must provide a recognized data type
-* @throws {TypeError} must provide a length, typed array, array-like object, or buffer
+* @throws {TypeError} must provide a length, typed array, array-like object, buffer, or iterable
 * @throws {Error} creating a generic array from an `ArrayBuffer` is not supported
 * @returns {(TypedArray|Array)} array or typed array
 *
@@ -137,8 +185,6 @@ function filledarray() {
 	var arr;
 	var len;
 	var arg;
-	var v;
-	var i;
 
 	nargs = arguments.length;
 	nargs -= 1;
@@ -165,13 +211,7 @@ function filledarray() {
 				len = arg.length;
 			}
 			if ( len !== void 0 ) {
-				arr = [];
-
-				// Manually push elements in order to ensure "fast" elements...
-				for ( i = 0; i < len; i++ ) {
-					arr.push( value );
-				}
-				return arr;
+				return filled( len, value );
 			}
 			if ( isArrayBuffer( arg ) ) {
 				throw new Error( 'invalid arguments. Creating a generic array from an ArrayBuffer is not supported.' );
@@ -187,17 +227,7 @@ function filledarray() {
 				if ( !isFunction( arg.next ) ) {
 					throw new TypeError( 'invalid argument. Must provide a length, typed array, array-like object, or an iterable.' );
 				}
-				arr = [];
-				while ( true ) {
-					v = arg.next();
-					if ( hasOwnProp( v, 'value' ) ) {
-						arr.push( value );
-					}
-					if ( v.done ) {
-						break;
-					}
-				}
-				return arr;
+				return filledIterator( arg, value );
 			}
 			throw new TypeError( 'invalid argument. Must provide a length, typed array, array-like object, or an iterable. Value: `'+arg+'`.' );
 		} else if ( isArrayBuffer( arg ) ) {
@@ -216,7 +246,7 @@ function filledarray() {
 		arr = new ctor( arguments[1], arguments[2], arguments[3] );
 	}
 	value = arguments[ 0 ];
-	if ( arr.length > 0 && value !== 0 ) { // i.e., nonzero
+	if ( arr.length > 0 && value !== 0 ) { // we only need to fill a typed array if the fill value isn't zero, as typed arrays are always zero-initialized
 		gfill( arr.length, value, arr, 1 );
 	}
 	return arr;
