Skip to content

Commit 6670125

Browse files
committed
Use built-ins
1 parent f373a32 commit 6670125

3 files changed

Lines changed: 11 additions & 10 deletions

File tree

lib/node_modules/@stdlib/string/format/lib/format_double.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@
2121
// MODULES //
2222

2323
var isUppercase = require( '@stdlib/assert/is-uppercase' );
24-
var uppercase = require( '@stdlib/string/uppercase' );
25-
var lowercase = require( '@stdlib/string/lowercase' );
2624
var replace = require( '@stdlib/string/replace' );
2725
var isfinite = require( '@stdlib/math/base/assert/is-finite' );
2826
var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
2927

3028
// NOTE: for the following, we explicitly avoid using stdlib packages in this particular package in order to avoid circular dependencies.
3129
var abs = Math.abs; // eslint-disable-line stdlib/no-builtin-math
30+
var lowercase = String.prototype.toLowerCase;
31+
var uppercase = String.prototype.toUpperCase;
3232

3333

3434
// VARIABLES //
@@ -102,8 +102,8 @@ function formatDouble( token ) {
102102
out = token.sign + out;
103103
}
104104
out = ( isUppercase( token.specifier ) ) ?
105-
uppercase( out ) :
106-
lowercase( out );
105+
uppercase.call( out ) :
106+
lowercase.call( out );
107107
return out;
108108
}
109109

lib/node_modules/@stdlib/string/format/lib/format_integer.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,14 @@
2121
// MODULES //
2222

2323
var isUppercase = require( '@stdlib/assert/is-uppercase' );
24-
var uppercase = require( '@stdlib/string/uppercase' );
25-
var lowercase = require( '@stdlib/string/lowercase' );
2624
var isfinite = require( '@stdlib/math/base/assert/is-finite' );
2725
var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
2826
var zeroPad = require( './zero_pad.js' );
2927

28+
// NOTE: for the following, we explicitly avoid using stdlib packages in this particular package in order to avoid circular dependencies.
29+
var lowercase = String.prototype.toLowerCase;
30+
var uppercase = String.prototype.toUpperCase;
31+
3032

3133
// MAIN //
3234

@@ -98,8 +100,8 @@ function formatInteger( token ) {
98100
out = '0x' + out;
99101
}
100102
out = ( isUppercase( token.specifier ) ) ?
101-
uppercase( out ) :
102-
lowercase( out );
103+
uppercase.call( out ) :
104+
lowercase.call( out );
103105
}
104106
if ( base === 8 ) {
105107
if ( token.alternate && out.charAt( 0 ) !== '0' ) {

lib/node_modules/@stdlib/string/format/lib/main.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
// MODULES //
2222

2323
var isString = require( '@stdlib/assert/is-string' ).isPrimitive;
24-
var contains = require( '@stdlib/assert/contains' );
2524
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2625
var formatInteger = require( './format_integer.js' );
2726
var formatDouble = require( './format_double.js' );
@@ -95,7 +94,7 @@ function format( str ) {
9594
token.padZeros = false;
9695
break;
9796
case '0':
98-
token.padZeros = !contains( flags, '-' );
97+
token.padZeros = !flags.includes( '-' ); // NOTE: We use built-in `Array.prototype.includes` here instead of `@stdlib/assert/contains` to avoid circular dependencies.
9998
break;
10099
case '#':
101100
token.alternate = true;

0 commit comments

Comments
 (0)