refactor: use accessor utility

kgryte · kgryte · commit 61db175f0cfa · 2023-10-11T18:07:56.000-07:00
diff --git a/lib/node_modules/@stdlib/ndarray/slice/lib/main.js b/lib/node_modules/@stdlib/ndarray/slice/lib/main.js
@@ -28,6 +28,7 @@ var isBoolean = require( '@stdlib/assert/is-boolean' ).isPrimitive;
 var hasOwnProp = require( '@stdlib/assert/has-own-property' );
 var MultiSlice = require( '@stdlib/slice/multi' );
 var base = require( '@stdlib/ndarray/base/slice' );
+var getShape = require( '@stdlib/ndarray/shape' );
 var format = require( '@stdlib/string/format' );
 
 
@@ -87,6 +88,7 @@ function slice( x, s ) {
 	var nargs;
 	var opts;
 	var args;
+	var sh;
 	var S;
 	var i;
 
@@ -106,8 +108,9 @@ function slice( x, s ) {
 			}
 			opts.strict = options.strict;
 		}
-		if ( nargs === 1 && x.shape.length > 0 ) {
-			throw new RangeError( format( 'invalid argument. Number of slice dimensions does not match the number of array dimensions. Array shape: (%s). Slice dimensions: %u.', x.shape.join( ',' ), 0 ) );
+		sh = getShape( x );
+		if ( nargs === 1 && sh.length > 0 ) {
+			throw new RangeError( format( 'invalid argument. Number of slice dimensions does not match the number of array dimensions. Array shape: (%s). Slice dimensions: %u.', sh.join( ',' ), 0 ) );
 		}
 	}
 	if ( isMultiSlice( s ) ) {

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ var isBoolean = require( '@stdlib/assert/is-boolean' ).isPrimitive;`
`28`	`28`	`var hasOwnProp = require( '@stdlib/assert/has-own-property' );`
`29`	`29`	`var MultiSlice = require( '@stdlib/slice/multi' );`
`30`	`30`	`var base = require( '@stdlib/ndarray/base/slice' );`
	`31`	`+var getShape = require( '@stdlib/ndarray/shape' );`
`31`	`32`	`var format = require( '@stdlib/string/format' );`
`32`	`33`
`33`	`34`
`@@ -87,6 +88,7 @@ function slice( x, s ) {`
`87`	`88`	`var nargs;`
`88`	`89`	`var opts;`
`89`	`90`	`var args;`
	`91`	`+ var sh;`
`90`	`92`	`var S;`
`91`	`93`	`var i;`
`92`	`94`
`@@ -106,8 +108,9 @@ function slice( x, s ) {`
`106`	`108`	`}`
`107`	`109`	`opts.strict = options.strict;`
`108`	`110`	`}`
`109`		`- if ( nargs === 1 && x.shape.length > 0 ) {`
`110`		`- throw new RangeError( format( 'invalid argument. Number of slice dimensions does not match the number of array dimensions. Array shape: (%s). Slice dimensions: %u.', x.shape.join( ',' ), 0 ) );`
	`111`	`+ sh = getShape( x );`
	`112`	`+ if ( nargs === 1 && sh.length > 0 ) {`
	`113`	`+ throw new RangeError( format( 'invalid argument. Number of slice dimensions does not match the number of array dimensions. Array shape: (%s). Slice dimensions: %u.', sh.join( ',' ), 0 ) );`
`111`	`114`	`}`
`112`	`115`	`}`
`113`	`116`	`if ( isMultiSlice( s ) ) {`