Ensure that the project can be sorted topologically before publishing

kgryte · kgryte · commit 5ad4baa7ae02 · 2021-08-23T03:03:12.000-07:00
diff --git a/tools/scripts/npm_publish b/tools/scripts/npm_publish
@@ -194,6 +194,21 @@ check_licenses() {
 	return 0
 }
 
+# Checks that the project can be sorted topologically.
+check_toposort() {
+	echo 'Performing a topological sort...' >&2
+	make list-pkgs-toposort >/dev/null
+	if [[ "$?" -ne 0 ]]; then
+		echo '' >&2
+		echo 'Error: unexpected error. Unable to perform a topological sort. This is likely due to a dependency cycle. Please resolve before publishing. Command: make list-pkgs-toposort.' >&2
+		echo '' >&2
+		return 1
+	fi
+	echo 'Successfully performed a topological sort.' >&2
+	echo '' >&2
+	return 0
+}
+
 # Updates package meta data.
 update_package_meta_data() {
 	echo 'Updating package meta data...' >&2
@@ -529,6 +544,10 @@ main() {
 	if [[ "$?" -ne 0 ]]; then
 		on_error 1
 	fi
+	check_toposort
+	if [[ "$?" -ne 0 ]]; then
+		on_error 1
+	fi
 	update_package_meta_data
 	if [[ "$?" -ne 0 ]]; then
 		revert_changes
