Skip to content

Commit 56a6ce8

Browse files
committed
refactor: do not require static byteLength method
In absence of Buffer polyfill, the existing code breaks bundles for multiple namespaces. Only accessing the static method at runtime should resolve these. --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent e28d2fe commit 56a6ce8

File tree

1 file changed

+3
-3
lines changed
  • lib/node_modules/@stdlib/net/disposable-http-server/lib

1 file changed

+3
-3
lines changed

lib/node_modules/@stdlib/net/disposable-http-server/lib/main.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ var isString = require( '@stdlib/assert/is-string' ).isPrimitive;
2929
var isFunction = require( '@stdlib/assert/is-function' );
3030
var openURL = require( '@stdlib/utils/open-url' );
3131
var noop = require( '@stdlib/utils/noop' );
32-
var buffer2bytelength = require( '@stdlib/buffer/ctor' ).byteLength;
32+
var Buffer = require( '@stdlib/buffer/ctor' );
3333
var string2buffer = require( '@stdlib/buffer/from-string' );
3434
var nextTick = require( '@stdlib/utils/next-tick' );
3535
var NODE_VERSION = require( '@stdlib/process/node-version' );
@@ -91,10 +91,10 @@ function onClose() {
9191
*/
9292
function byteLength( str ) { // TODO: consider making a robust utility in `@stdlib/buffer/byte-length`
9393
if ( SUPPORTS_BUFFER ) {
94-
return buffer2bytelength( str );
94+
return Buffer.byteLength( str );
9595
}
9696
// Earlier versions of Node.js do not support Buffers, ArrayBuffers, TypedArrays, DataViews, or SharedArrayBuffers, so we need to explicitly call `#.toString()`...
97-
return buffer2bytelength( str.toString() );
97+
return Buffer.byteLength( str.toString() );
9898
}
9999

100100

0 commit comments

Comments
 (0)