Use global isFinite function

Planeshifter · Planeshifter · commit 4b85633b28ea · 2022-03-16T02:24:02.000-04:00
diff --git a/lib/node_modules/@stdlib/string/format/lib/format_double.js b/lib/node_modules/@stdlib/string/format/lib/format_double.js
@@ -21,7 +21,6 @@
 // MODULES //
 
 var isUppercase = require( '@stdlib/assert/is-uppercase' );
-var isfinite = require( '@stdlib/math/base/assert/is-finite' );
 var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
 
 // NOTE: for the following, we explicitly avoid using stdlib packages in this particular package in order to avoid circular dependencies.
@@ -56,7 +55,7 @@ function formatDouble( token ) {
 	var digits;
 	var out;
 	var f = parseFloat( token.arg );
-	if ( !isfinite( f ) ) {
+	if ( !isFinite( f ) ) { // NOTE: We use the global `isFinite` function here instead of `@stdlib/math/base/assert/is-finite` to avoid circular dependencies.
 		if ( !isNumber( token.arg ) ) {
 			throw new Error( 'invalid floating-point number. Value: ' + out );
 		}
diff --git a/lib/node_modules/@stdlib/string/format/lib/format_integer.js b/lib/node_modules/@stdlib/string/format/lib/format_integer.js
@@ -21,7 +21,6 @@
 // MODULES //
 
 var isUppercase = require( '@stdlib/assert/is-uppercase' );
-var isfinite = require( '@stdlib/math/base/assert/is-finite' );
 var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
 var zeroPad = require( './zero_pad.js' );
 
@@ -69,7 +68,7 @@ function formatInteger( token ) {
 	}
 	out = token.arg;
 	i = parseInt( out, 10 );
-	if ( !isfinite( i ) ) {
+	if ( !isFinite( i ) ) { // NOTE: We use the global `isFinite` function here instead of `@stdlib/math/base/assert/is-finite` to avoid circular dependencies.
 		if ( !isNumber( out ) ) {
 			throw new Error( 'invalid integer. Value: ' + out );
 		}

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,6 @@`
`21`	`21`	`// MODULES //`
`22`	`22`
`23`	`23`	`var isUppercase = require( '@stdlib/assert/is-uppercase' );`
`24`		`-var isfinite = require( '@stdlib/math/base/assert/is-finite' );`
`25`	`24`	`var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;`
`26`	`25`	`var zeroPad = require( './zero_pad.js' );`
`27`	`26`
`@@ -69,7 +68,7 @@ function formatInteger( token ) {`
`69`	`68`	`}`
`70`	`69`	`out = token.arg;`
`71`	`70`	`i = parseInt( out, 10 );`
`72`		`- if ( !isfinite( i ) ) {`
	`71`	+ if ( !isFinite( i ) ) { // NOTE: We use the global `isFinite` function here instead of `@stdlib/math/base/assert/is-finite` to avoid circular dependencies.
`73`	`72`	`if ( !isNumber( out ) ) {`
`74`	`73`	`throw new Error( 'invalid integer. Value: ' + out );`
`75`	`74`	`}`