fix: refactor build script and newline handling in workflow

Planeshifter · Planeshifter · commit 4ad35bbe7201 · 2023-08-11T15:25:46.000-04:00
diff --git a/.github/workflows/update_error_databases.yml b/.github/workflows/update_error_databases.yml
@@ -117,10 +117,8 @@ jobs:
           # Generate a comment body:
           body="This PR\n\n-   updates the error databases\n\nThe following error codes were added:\n\n${table}"
           
-          # Add the comment body to the workflow output after escaping to preserve newlines:
-          body="${body//'%'/'%25'}"
-          body="${body//$'\n'/'%0A'}"
-          body="${body//$'\r'/'%0D'}"
+          # Add the comment body to the workflow output after escaping to render newlines:
+          body="${body//\\n/'%0A'}"
           echo "body=${body}" >> $GITHUB_OUTPUT
 
       # Disable Git hooks:
diff --git a/lib/node_modules/@stdlib/error/tools/database/scripts/build.js b/lib/node_modules/@stdlib/error/tools/database/scripts/build.js
@@ -27,7 +27,8 @@ var shell = require( 'child_process' ).execSync;
 var logger = require( 'debug' );
 var writeFile = require( '@stdlib/fs/write-file' ).sync;
 var objectKeys = require( '@stdlib/utils/keys' );
-var data = require( './../data/data.json' );
+var merge = require( '@stdlib/utils/merge' );
+var existing = require( './../data/data.json' );
 
 
 // VARIABLES //
@@ -125,6 +126,7 @@ function main() {
 	var codes;
 	var fopts;
 	var code;
+	var data;
 	var msgs;
 	var next;
 	var keys;
@@ -136,10 +138,10 @@ function main() {
 	debug( 'Extracting errors and generate error codes if not yet present...' );
 	messages = new Set();
 	next = '00';
-	codes = objectKeys( data );
+	codes = objectKeys( existing );
 	for ( i = 0; i < codes.length; i++ ) {
 		code = codes[ i ];
-		messages.add( data[ code ] );
+		messages.add( existing[ code ] );
 		if ( code >= next ) {
 			next = nextCode( code );
 		}
@@ -182,6 +184,7 @@ function main() {
 	debug( 'Executing command: %s', command );
 	msgs = msgs.concat( shell( command ).toString().split( '\n' ) );
 
+	data = {};
 	types = {};
 	for ( i = 0; i < msgs.length; i++ ) {
 		msg = msgs[ i ];
@@ -203,11 +206,12 @@ function main() {
 	fopts = {
 		'encoding': 'utf8'
 	};
-	writeFile( OUTPUT_JSON, JSON.stringify( data ), fopts );
+	writeFile( OUTPUT_JSON, JSON.stringify( merge( existing, data ), fopts ) );
 
 	debug( 'Writing to CSV file...' );
 	fopts = {
-		'encoding': 'utf8'
+		'encoding': 'utf8',
+		'flag': 'a' // Append to existing file
 	};
 	keys = objectKeys( data );
 	csv = '';
