Fix bug when computing correction term

kgryte · kgryte · commit 3b0aaac0d5fb · 2020-07-01T14:38:06.000-07:00
diff --git a/lib/node_modules/@stdlib/stats/base/dsvariancepn/lib/dsvariancepn.js b/lib/node_modules/@stdlib/stats/base/dsvariancepn/lib/dsvariancepn.js
@@ -85,8 +85,7 @@ function dsvariancepn( N, correction, x, stride ) {
 		M += d;
 		ix += stride;
 	}
-	M /= n;
-	return (M2/n) - (M*M);
+	return (M2/n) - ((M/N)*(M/n));
 }
 
 
diff --git a/lib/node_modules/@stdlib/stats/base/dsvariancepn/lib/ndarray.js b/lib/node_modules/@stdlib/stats/base/dsvariancepn/lib/ndarray.js
@@ -83,8 +83,7 @@ function dsvariancepn( N, correction, x, stride, offset ) {
 		M += d;
 		ix += stride;
 	}
-	M /= n;
-	return (M2/n) - (M*M);
+	return (M2/n) - ((M/N)*(M/n));
 }
 
 
diff --git a/lib/node_modules/@stdlib/stats/base/dsvariancepn/src/dsvariancepn.c b/lib/node_modules/@stdlib/stats/base/dsvariancepn/src/dsvariancepn.c
@@ -71,6 +71,5 @@ double stdlib_strided_dsvariancepn( const int64_t N, const float correction, con
 		M += d;
 		ix += stride;
 	}
-	M /= n;
-	return (M2/n) - (M*M);
+	return (M2/n) - ((M/N)*(M/n));
 }
diff --git a/lib/node_modules/@stdlib/stats/base/dvariancepn/lib/dvariancepn.js b/lib/node_modules/@stdlib/stats/base/dvariancepn/lib/dvariancepn.js
@@ -85,8 +85,7 @@ function dvariancepn( N, correction, x, stride ) {
 		M += d;
 		ix += stride;
 	}
-	M /= n;
-	return (M2/n) - (M*M);
+	return (M2/n) - ((M/N)*(M/n));
 }
 
 
diff --git a/lib/node_modules/@stdlib/stats/base/dvariancepn/lib/ndarray.js b/lib/node_modules/@stdlib/stats/base/dvariancepn/lib/ndarray.js
@@ -83,8 +83,7 @@ function dvariancepn( N, correction, x, stride, offset ) {
 		M += d;
 		ix += stride;
 	}
-	M /= n;
-	return (M2/n) - (M*M);
+	return (M2/n) - ((M/N)*(M/n));
 }
 
 
diff --git a/lib/node_modules/@stdlib/stats/base/dvariancepn/src/dvariancepn.c b/lib/node_modules/@stdlib/stats/base/dvariancepn/src/dvariancepn.c
@@ -71,6 +71,5 @@ double stdlib_strided_dvariancepn( const int64_t N, const double correction, con
 		M += d;
 		ix += stride;
 	}
-	M /= n;
-	return (M2/n) - (M*M);
+	return (M2/n) - ((M/N)*(M/n));
 }
diff --git a/lib/node_modules/@stdlib/stats/base/svariancepn/lib/ndarray.js b/lib/node_modules/@stdlib/stats/base/svariancepn/lib/ndarray.js
@@ -84,8 +84,7 @@ function svariancepn( N, correction, x, stride, offset ) {
 		M = float64ToFloat32( M + d );
 		ix += stride;
 	}
-	M = float64ToFloat32( M / n );
-	return float64ToFloat32( float64ToFloat32(M2/n) - float64ToFloat32(M*M) );
+	return float64ToFloat32( float64ToFloat32(M2/n) - float64ToFloat32( float64ToFloat32(M/N)*float64ToFloat32(M/n) ) ); // eslint-disable-line max-len
 }
 
 
diff --git a/lib/node_modules/@stdlib/stats/base/svariancepn/lib/svariancepn.js b/lib/node_modules/@stdlib/stats/base/svariancepn/lib/svariancepn.js
@@ -86,8 +86,7 @@ function svariancepn( N, correction, x, stride ) {
 		M = float64ToFloat32( M + d );
 		ix += stride;
 	}
-	M = float64ToFloat32( M / n );
-	return float64ToFloat32( float64ToFloat32(M2/n) - float64ToFloat32(M*M) );
+	return float64ToFloat32( float64ToFloat32(M2/n) - float64ToFloat32( float64ToFloat32(M/N)*float64ToFloat32(M/n) ) ); // eslint-disable-line max-len
 }
 
 
diff --git a/lib/node_modules/@stdlib/stats/base/svariancepn/src/svariancepn.c b/lib/node_modules/@stdlib/stats/base/svariancepn/src/svariancepn.c
@@ -71,6 +71,5 @@ float stdlib_strided_svariancepn( const int64_t N, const float correction, const
 		M += d;
 		ix += stride;
 	}
-	M /= n;
-	return (M2/n) - (M*M);
+	return (M2/n) - ((M/N)*(M/n));
 }
diff --git a/lib/node_modules/@stdlib/stats/base/variancepn/lib/ndarray.js b/lib/node_modules/@stdlib/stats/base/variancepn/lib/ndarray.js
@@ -82,8 +82,7 @@ function variancepn( N, correction, x, stride, offset ) {
 		M += d;
 		ix += stride;
 	}
-	M /= n;
-	return (M2/n) - (M*M);
+	return (M2/n) - ((M/N)*(M/n));
 }
 
 
diff --git a/lib/node_modules/@stdlib/stats/base/variancepn/lib/variancepn.js b/lib/node_modules/@stdlib/stats/base/variancepn/lib/variancepn.js
@@ -83,8 +83,7 @@ function variancepn( N, correction, x, stride ) {
 		M += d;
 		ix += stride;
 	}
-	M /= n;
-	return (M2/n) - (M*M);
+	return (M2/n) - ((M/N)*(M/n));
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -85,8 +85,7 @@ function dsvariancepn( N, correction, x, stride ) {`
`85`	`85`	`M += d;`
`86`	`86`	`ix += stride;`
`87`	`87`	`}`
`88`		`- M /= n;`
`89`		`- return (M2/n) - (M*M);`
	`88`	`+ return (M2/n) - ((M/N)*(M/n));`
`90`	`89`	`}`
`91`	`90`
`92`	`91`
Original file line number	Diff line number	Diff line change
`@@ -83,8 +83,7 @@ function dsvariancepn( N, correction, x, stride, offset ) {`
`83`	`83`	`M += d;`
`84`	`84`	`ix += stride;`
`85`	`85`	`}`
`86`		`- M /= n;`
`87`		`- return (M2/n) - (M*M);`
	`86`	`+ return (M2/n) - ((M/N)*(M/n));`
`88`	`87`	`}`
`89`	`88`
`90`	`89`
Original file line number	Diff line number	Diff line change
`@@ -71,6 +71,5 @@ double stdlib_strided_dsvariancepn( const int64_t N, const float correction, con`
`71`	`71`	`M += d;`
`72`	`72`	`ix += stride;`
`73`	`73`	`}`
`74`		`- M /= n;`
`75`		`- return (M2/n) - (M*M);`
	`74`	`+ return (M2/n) - ((M/N)*(M/n));`
`76`	`75`	`}`
Original file line number	Diff line number	Diff line change
`@@ -85,8 +85,7 @@ function dvariancepn( N, correction, x, stride ) {`
`85`	`85`	`M += d;`
`86`	`86`	`ix += stride;`
`87`	`87`	`}`
`88`		`- M /= n;`
`89`		`- return (M2/n) - (M*M);`
	`88`	`+ return (M2/n) - ((M/N)*(M/n));`
`90`	`89`	`}`
`91`	`90`
`92`	`91`
Original file line number	Diff line number	Diff line change
`@@ -83,8 +83,7 @@ function dvariancepn( N, correction, x, stride, offset ) {`
`83`	`83`	`M += d;`
`84`	`84`	`ix += stride;`
`85`	`85`	`}`
`86`		`- M /= n;`
`87`		`- return (M2/n) - (M*M);`
	`86`	`+ return (M2/n) - ((M/N)*(M/n));`
`88`	`87`	`}`
`89`	`88`
`90`	`89`
Original file line number	Diff line number	Diff line change
`@@ -84,8 +84,7 @@ function svariancepn( N, correction, x, stride, offset ) {`
`84`	`84`	`M = float64ToFloat32( M + d );`
`85`	`85`	`ix += stride;`
`86`	`86`	`}`
`87`		`- M = float64ToFloat32( M / n );`
`88`		`- return float64ToFloat32( float64ToFloat32(M2/n) - float64ToFloat32(M*M) );`
	`87`	`+ return float64ToFloat32( float64ToFloat32(M2/n) - float64ToFloat32( float64ToFloat32(M/N)*float64ToFloat32(M/n) ) ); // eslint-disable-line max-len`
`89`	`88`	`}`
`90`	`89`
`91`	`90`
Original file line number	Diff line number	Diff line change
`@@ -86,8 +86,7 @@ function svariancepn( N, correction, x, stride ) {`
`86`	`86`	`M = float64ToFloat32( M + d );`
`87`	`87`	`ix += stride;`
`88`	`88`	`}`
`89`		`- M = float64ToFloat32( M / n );`
`90`		`- return float64ToFloat32( float64ToFloat32(M2/n) - float64ToFloat32(M*M) );`
	`89`	`+ return float64ToFloat32( float64ToFloat32(M2/n) - float64ToFloat32( float64ToFloat32(M/N)*float64ToFloat32(M/n) ) ); // eslint-disable-line max-len`
`91`	`90`	`}`
`92`	`91`
`93`	`92`
Original file line number	Diff line number	Diff line change
`@@ -71,6 +71,5 @@ float stdlib_strided_svariancepn( const int64_t N, const float correction, const`
`71`	`71`	`M += d;`
`72`	`72`	`ix += stride;`
`73`	`73`	`}`
`74`		`- M /= n;`
`75`		`- return (M2/n) - (M*M);`
	`74`	`+ return (M2/n) - ((M/N)*(M/n));`
`76`	`75`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,8 +82,7 @@ function variancepn( N, correction, x, stride, offset ) {`
`82`	`82`	`M += d;`
`83`	`83`	`ix += stride;`
`84`	`84`	`}`
`85`		`- M /= n;`
`86`		`- return (M2/n) - (M*M);`
	`85`	`+ return (M2/n) - ((M/N)*(M/n));`
`87`	`86`	`}`
`88`	`87`
`89`	`88`