Add support for generating a browserify bundle using external requires

kgryte · kgryte · commit 27081feb8132 · 2017-09-19T15:10:17.000-07:00
diff --git a/lib/node_modules/@stdlib/_tools/bundle/pkg-list/lib/main.js b/lib/node_modules/@stdlib/_tools/bundle/pkg-list/lib/main.js
@@ -3,6 +3,7 @@
 // MODULES //
 
 var debug = require( 'debug' )( 'bundle-pkg-list:main' );
+var browserify = require( 'browserify' );
 var copy = require( '@stdlib/utils/copy' );
 var isStringArray = require( '@stdlib/assert/is-string-array' ).primitives;
 var isFunction = require( '@stdlib/assert/is-function' );
@@ -52,10 +53,12 @@ var toTreeNamespace = require( './to_tree.js' );
 * }
 */
 function bundle( pkgs, options, clbk ) {
+	var bopts;
 	var opts;
 	var err;
 	var out;
 	var cb;
+	var b;
 
 	if ( !isStringArray( pkgs ) ) {
 		throw new TypeError( 'invalid input argument. First argument must be an array of strings. Value: `'+pkgs+'`.' );
@@ -81,8 +84,17 @@ function bundle( pkgs, options, clbk ) {
 	// Remove duplicates:
 	pkgs = unique( pkgs );
 
-	// TODO: if namespace if "none" and bundler is "browserify", pursue a bundle which exposes an external `require`
+	// If we do not need to generate a namespace for a browserify bundle, we will generate a bundle which allows a bundle consumer to `require` each package individually...
+	if ( opts.namespace === 'none' && opts.bundler === 'browserify' ) {
+		bopts = {
+			'externalRequireName': opts.requireName,
+			'require': pkgs
+		};
+		b = browserify( bopts );
+		return b.bundle( onBundle );
+	}
 
+	// Generate a namespace...
 	if ( opts.namespace === 'flat' ) {
 		debug( 'Generating a flat namespace...' );
 
@@ -98,18 +110,37 @@ function bundle( pkgs, options, clbk ) {
 
 		out = toTreeNamespace( pkgs );
 	}
+	debug( 'Finished generating a namespace.' );
+
 	return done( null, out );
 	// TODO: generate temporary file
 	// TODO: bundle the file
 	// TODO: delete temporary file
 	// TODO: return the bundle
 
+	/**
+	* Callback invoked upon generating a browserify bundle.
+	*
+	* @private
+	* @param {(Error|null)} error - error object
+	* @param {(string|Buffer)} bundle - bundle
+	* @returns {void}
+	*/
+	function onBundle( error, bundle ) {
+		if ( error ) {
+			debug( 'Encountered an error when generating a browserify bundle: %s', error.message );
+			return done( error );
+		}
+		debug( 'Successfully generated a browserify bundle.' );
+		done( null, bundle );
+	} // end FUNCTION onBundle()
+
 	/**
 	* Callback invoked upon completion.
 	*
 	* @private
 	* @param {(Error|null)} error - error object
-	* @param {string} bundle - bundle
+	* @param {(string|Buffer)} bundle - bundle
 	* @returns {void}
 	*/
 	function done( error, bundle ) {
