Skip to content

Commit 1ccb53d

Browse files
kgrytekgryte
committed
Add support for ignoring failed files
1 parent 995c4b2 commit 1ccb53d

1 file changed

Lines changed: 32 additions & 0 deletions

File tree

‎tools/make/lib/lint/javascript/eslint.mk‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,19 @@ endif
7878
# This target lints only JavaScript test files.
7979

8080
eslint-tests: $(NODE_MODULES)
81+
ifeq ($(FAIL_FAST), true)
8182
$(QUIET) $(FIND_TESTS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
8283
echo ''; \
8384
echo "Linting file: $$file"; \
8485
$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_TESTS) $$file || exit 1; \
8586
done
87+
else
88+
$(QUIET) $(FIND_TESTS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
89+
echo ''; \
90+
echo "Linting file: $$file"; \
91+
$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_TESTS) $$file; \
92+
done
93+
endif
8694

8795
.PHONY: eslint-tests
8896

@@ -92,11 +100,19 @@ eslint-tests: $(NODE_MODULES)
92100
# This target lints only JavaScript example files.
93101

94102
eslint-examples: $(NODE_MODULES)
103+
ifeq ($(FAIL_FAST), true)
95104
$(QUIET) $(FIND_EXAMPLES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
96105
echo ''; \
97106
echo "Linting file: $$file"; \
98107
$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_EXAMPLES) $$file || exit 1; \
99108
done
109+
else
110+
$(QUIET) $(FIND_EXAMPLES_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
111+
echo ''; \
112+
echo "Linting file: $$file"; \
113+
$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_EXAMPLES) $$file; \
114+
done
115+
endif
100116

101117
.PHONY: eslint-examples
102118

@@ -106,11 +122,19 @@ eslint-examples: $(NODE_MODULES)
106122
# This target lints only JavaScript benchmark files.
107123

108124
eslint-benchmarks: $(NODE_MODULES)
125+
ifeq ($(FAIL_FAST), true)
109126
$(QUIET) $(FIND_BENCHMARKS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
110127
echo ''; \
111128
echo "Linting file: $$file"; \
112129
$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_BENCHMARKS) $$file || exit 1; \
113130
done
131+
else
132+
$(QUIET) $(FIND_BENCHMARKS_CMD) | grep '^[\/]\|^[a-zA-Z]:[/\]' | while read -r file; do \
133+
echo ''; \
134+
echo "Linting file: $$file"; \
135+
$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF_BENCHMARKS) $$file; \
136+
done
137+
endif
114138

115139
.PHONY: eslint-benchmarks
116140

@@ -120,10 +144,18 @@ eslint-benchmarks: $(NODE_MODULES)
120144
# This target lints JavaScript files. Note that we expect `$FILES` to be a JavaScript file list.
121145

122146
eslint-files: $(NODE_MODULES)
147+
ifeq ($(FAIL_FAST), true)
123148
$(QUIET) for file in $(FILES); do \
124149
echo ''; \
125150
echo "Linting file: $$file"; \
126151
$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF) $$file || exit 1; \
127152
done
153+
else
154+
$(QUIET) for file in $(FILES); do \
155+
echo ''; \
156+
echo "Linting file: $$file"; \
157+
$(ESLINT) $(ESLINT_FLAGS) --config $(ESLINT_CONF) $$file; \
158+
done
159+
endif
128160

129161
.PHONY: eslint-files

0 commit comments

Comments
 (0)