Remove throw and replace with message and non-zero exit code

kgryte · kgryte · commit 190e3f9f4ca3 · 2017-07-20T23:49:39.000-07:00
diff --git a/lib/node_modules/@stdlib/string/lowercase/bin/cli b/lib/node_modules/@stdlib/string/lowercase/bin/cli
@@ -18,14 +18,15 @@ var lowercase = require( './../lib' );
 * @private
 * @param {(Error|null)} error - error object
 * @param {Buffer} data - data
-* @throws {Error} unexpected error
 * @returns {void}
 */
 function onRead( error, data ) {
+	/* eslint-disable no-console */
 	if ( error ) {
-		throw error;
+		process.exitCode = 1;
+		return console.error( 'Error: %s', error.message );
 	}
-	console.log( lowercase( data.toString() ) ); // eslint-disable-line no-console
+	console.log( lowercase( data.toString() ) );
 } // end FUNCTION onRead()
 
 
diff --git a/lib/node_modules/@stdlib/string/lowercase/test/test.cli.js b/lib/node_modules/@stdlib/string/lowercase/test/test.cli.js
@@ -163,7 +163,7 @@ tape( 'the command-line interface supports use as a standard stream', opts, func
 	}
 });
 
-tape( 'when used as a standard stream, if an error is encountered when reading from `stdin`, the command-line interface throws an error', opts, function test( t ) {
+tape( 'when used as a standard stream, if an error is encountered when reading from `stdin`, the command-line interface prints an error and sets a non-zero exit code', opts, function test( t ) {
 	var script;
 	var opts;
 	var cmd;
@@ -187,12 +187,13 @@ tape( 'when used as a standard stream, if an error is encountered when reading f
 
 	exec( cmd.join( ' ' ), opts, done );
 
-	function done( error ) {
+	function done( error, stdout, stderr ) {
 		if ( error ) {
 			t.pass( error.message );
-		} else {
-			t.fail( 'should return an error' );
+			t.strictEqual( error.code, 1, 'expected exit code' );
 		}
+		t.strictEqual( stdout.toString(), '', 'does not print to `stdout`' );
+		t.strictEqual( stderr.toString(), 'Error: beep\n', 'expected value' );
 		t.end();
 	}
 });
