Refactor to ignore iterator return value

kgryte · kgryte · commit 0956d9e95fc5 · 2022-05-31T23:30:07.000-07:00
diff --git a/lib/node_modules/@stdlib/stats/iter/variance/benchmark/benchmark.js b/lib/node_modules/@stdlib/stats/iter/variance/benchmark/benchmark.js
@@ -38,23 +38,26 @@ function createIterator( arr ) {
 
 	it = {};
 	it.next = next;
+	it.reset = reset;
 
 	return it;
 
 	function next() {
 		i += 1;
-		if ( i < len-1 ) {
+		if ( i < len ) {
 			return {
 				'value': arr[ i ],
 				'done': false
 			};
 		}
-		i = -1; // reset index
 		return {
-			'value': arr[ len-1 ],
 			'done': true
 		};
 	}
+
+	function reset() {
+		i = -1;
+	}
 }
 
 
@@ -73,6 +76,7 @@ bench( pkg, function benchmark( b ) {
 		if ( isnan( v ) ) {
 			b.fail( 'should not return NaN' );
 		}
+		arr.reset();
 	}
 	b.toc();
 	if ( isnan( v ) ) {
diff --git a/lib/node_modules/@stdlib/stats/iter/variance/lib/main.js b/lib/node_modules/@stdlib/stats/iter/variance/lib/main.js
@@ -21,7 +21,6 @@
 // MODULES //
 
 var isIteratorLike = require( '@stdlib/assert/is-iterator-like' );
-var hasOwnProp = require( '@stdlib/assert/has-own-property' );
 var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
 var incrvariance = require( '@stdlib/stats/incr/variance' );
 var format = require( '@stdlib/string/format' );
@@ -64,14 +63,14 @@ function itervariance( iterator, mean ) {
 	}
 	while ( true ) {
 		v = iterator.next();
+		if ( v.done ) {
+			break;
+		}
 		if ( typeof v.value === 'number' ) {
 			acc( v.value );
-		} else if ( hasOwnProp( v, 'value' ) ) {
+		} else {
 			acc( NaN );
 		}
-		if ( v.done ) {
-			break;
-		}
 	}
 	return acc();
 }
