Add support for empty arrays

kgryte · kgryte · commit 081b2b8c9839 · 2022-01-19T23:08:17.000-08:00
diff --git a/lib/node_modules/@stdlib/ndarray/zeros/lib/main.js b/lib/node_modules/@stdlib/ndarray/zeros/lib/main.js
@@ -104,7 +104,11 @@ function zeros( shape ) {
 	if ( buf === null ) {
 		throw new TypeError( 'invalid option. `dtype` option must be a recognized data type. Value: `' + opts.dtype + '`.' );
 	}
-	st = shape2strides( sh, opts.order );
+	if ( sh.length === 0 ) {
+		st = [ 0 ];
+	} else {
+		st = shape2strides( sh, opts.order );
+	}
 	return new ndarray( opts.dtype, buf, sh, st, strides2offset( sh, st ), opts.order ); // eslint-disable-line max-len
 }
 
diff --git a/lib/node_modules/@stdlib/ndarray/zeros/test/test.js b/lib/node_modules/@stdlib/ndarray/zeros/test/test.js
@@ -823,3 +823,42 @@ tape( 'the function returns a zero-filled array (dtype=generic, order=column-maj
 
 	t.end();
 });
+
+tape( 'the function supports empty arrays', function test( t ) {
+	var expected;
+	var arr;
+
+	expected = new Float64Array( 0 );
+
+	arr = zeros( [] );
+	t.strictEqual( instanceOf( arr, ndarray ), true, 'returns expected value' );
+	t.strictEqual( arr.dtype, 'float64', 'returns expected value' );
+	t.deepEqual( arr.shape, [], 'returns expected value' );
+	t.strictEqual( instanceOf( arr.data, Float64Array ), true, 'returns expected value' );
+	t.deepEqual( arr.data, expected, 'returns expected value' );
+	t.strictEqual( arr.order, 'row-major' );
+
+	t.end();
+});
+
+tape( 'the function supports empty arrays (options)', function test( t ) {
+	var expected;
+	var opts;
+	var arr;
+
+	expected = [];
+
+	opts = {
+		'dtype': 'generic',
+		'order': 'row-major'
+	};
+	arr = zeros( [], opts );
+	t.strictEqual( instanceOf( arr, ndarray ), true, 'returns expected value' );
+	t.strictEqual( arr.dtype, opts.dtype, 'returns expected value' );
+	t.deepEqual( arr.shape, [], 'returns expected value' );
+	t.strictEqual( instanceOf( arr.data, Array ), true, 'returns expected value' );
+	t.deepEqual( arr.data, expected, 'returns expected value' );
+	t.strictEqual( arr.order, opts.order );
+
+	t.end();
+});

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,11 @@ function zeros( shape ) {`
`104`	`104`	`if ( buf === null ) {`
`105`	`105`	throw new TypeError( 'invalid option. `dtype` option must be a recognized data type. Value: `' + opts.dtype + '`.' );
`106`	`106`	`}`
`107`		`- st = shape2strides( sh, opts.order );`
	`107`	`+ if ( sh.length === 0 ) {`
	`108`	`+ st = [ 0 ];`
	`109`	`+ } else {`
	`110`	`+ st = shape2strides( sh, opts.order );`
	`111`	`+ }`
`108`	`112`	`return new ndarray( opts.dtype, buf, sh, st, strides2offset( sh, st ), opts.order ); // eslint-disable-line max-len`
`109`	`113`	`}`
`110`	`114`