Refactor to ignore iterator return value

kgryte · kgryte · commit 0720bf3d4672 · 2022-06-01T15:49:40.000-07:00
diff --git a/lib/node_modules/@stdlib/stats/iter/mmaxabs/README.md b/lib/node_modules/@stdlib/stats/iter/mmaxabs/README.md
@@ -108,12 +108,12 @@ var it = itermmaxabs( rand, 3 );
 var v;
 while ( true ) {
     v = it.next();
-    if ( typeof v.value === 'number' ) {
-        console.log( 'maxabs: %d', v.value );
-    }
     if ( v.done ) {
         break;
     }
+    if ( typeof v.value === 'number' ) {
+        console.log( 'maxabs: %d', v.value );
+    }
 }
 ```
 
diff --git a/lib/node_modules/@stdlib/stats/iter/mmaxabs/examples/index.js b/lib/node_modules/@stdlib/stats/iter/mmaxabs/examples/index.js
@@ -34,10 +34,10 @@ var it = itermmaxabs( rand, 3 );
 var v;
 while ( true ) {
 	v = it.next();
-	if ( typeof v.value === 'number' ) {
-		console.log( 'maxabs: %d', v.value );
-	}
 	if ( v.done ) {
 		break;
 	}
+	if ( typeof v.value === 'number' ) {
+		console.log( 'maxabs: %d', v.value );
+	}
 }
diff --git a/lib/node_modules/@stdlib/stats/iter/mmaxabs/lib/main.js b/lib/node_modules/@stdlib/stats/iter/mmaxabs/lib/main.js
@@ -24,7 +24,6 @@ var setReadOnly = require( '@stdlib/utils/define-nonenumerable-read-only-propert
 var isIteratorLike = require( '@stdlib/assert/is-iterator-like' );
 var isPositiveInteger = require( '@stdlib/assert/is-positive-integer' ).isPrimitive;
 var isFunction = require( '@stdlib/assert/is-function' );
-var hasOwnProp = require( '@stdlib/assert/has-own-property' );
 var iteratorSymbol = require( '@stdlib/symbol/iterator' );
 var incrmmaxabs = require( '@stdlib/stats/incr/mmaxabs' );
 var format = require( '@stdlib/string/format' );
@@ -91,27 +90,28 @@ function itermmaxabs( iterator, W ) {
 	* @returns {Object} iterator protocol-compliant object
 	*/
 	function next() {
-		var out;
 		var v;
 		if ( FLG ) {
 			return {
 				'done': true
 			};
 		}
-		out = {};
 		v = iterator.next();
-		if ( typeof v.value === 'number' ) {
-			out.value = acc( v.value );
-		} else if ( hasOwnProp( v, 'value' ) ) {
-			out.value = acc( NaN );
-		}
 		if ( v.done ) {
 			FLG = true;
-			out.done = true;
+			return {
+				'done': true
+			};
+		}
+		if ( typeof v.value === 'number' ) {
+			v = acc( v.value );
 		} else {
-			out.done = false;
+			v = acc( NaN );
 		}
-		return out;
+		return {
+			'value': v,
+			'done': false
+		};
 	}
 
 	/**
diff --git a/lib/node_modules/@stdlib/stats/iter/mmaxabs/test/test.js b/lib/node_modules/@stdlib/stats/iter/mmaxabs/test/test.js
@@ -125,64 +125,6 @@ tape( 'the function returns an iterator protocol-compliant object which iterativ
 	t.end();
 });
 
-tape( 'the function returns an iterator protocol-compliant object which iteratively computes a moving maximum absolute value (value+done)', function test( t ) {
-	var expected;
-	var actual;
-	var values;
-	var it;
-	var v;
-	var i;
-
-	values = [ 2.0, -3.0, 2.0, -4.0, 3.0, -4.0 ];
-	expected = [ 2.0, 3.0, 3.0, 4.0, 4.0, 4.0 ];
-
-	it = itermmaxabs( createIterator( values ), 3 );
-	t.equal( it.next.length, 0, 'has zero arity' );
-
-	actual = [];
-	for ( i = 0; i < values.length; i++ ) {
-		v = it.next();
-		t.equal( typeof v.value, 'number', 'returns a number' );
-		t.equal( typeof v.done, 'boolean', 'returns a boolean' );
-		actual.push( v.value );
-	}
-	t.deepEqual( actual, expected, 'returns expected values' );
-
-	v = it.next();
-	t.equal( v.value, void 0, 'returns expected value' );
-	t.equal( v.done, true, 'returns expected value' );
-
-	t.end();
-
-	function createIterator( arr ) {
-		var len;
-		var it;
-		var i;
-
-		len = arr.length;
-		i = -1;
-
-		it = {};
-		it.next = next;
-
-		return it;
-
-		function next() {
-			var out;
-			i += 1;
-			if ( i < len ) {
-				out = {};
-				out.value = arr[ i ];
-				out.done = ( i === len-1 );
-				return out;
-			}
-			return {
-				'done': true
-			};
-		}
-	}
-});
-
 tape( 'if an iterated value is a non-numeric value, the computed maximum absolute value is `NaN` for at least `W` invocations', function test( t ) {
 	var expected;
 	var values;

Original file line number	Diff line number	Diff line change
`@@ -34,10 +34,10 @@ var it = itermmaxabs( rand, 3 );`
`34`	`34`	`var v;`
`35`	`35`	`while ( true ) {`
`36`	`36`	`v = it.next();`
`37`		`- if ( typeof v.value === 'number' ) {`
`38`		`- console.log( 'maxabs: %d', v.value );`
`39`		`- }`
`40`	`37`	`if ( v.done ) {`
`41`	`38`	`break;`
`42`	`39`	`}`
	`40`	`+ if ( typeof v.value === 'number' ) {`
	`41`	`+ console.log( 'maxabs: %d', v.value );`
	`42`	`+ }`
`43`	`43`	`}`