Reduce logging overhead (OpenFeign#439)

schlosna · adriancole · commit 3c23f1d8cc68 · 2016-08-16T12:06:13.000+08:00
* Avoid overhead when logging is disabled.
diff --git a/core/src/main/java/feign/Logger.java b/core/src/main/java/feign/Logger.java
@@ -178,7 +178,9 @@ protected Response logAndRebufferResponse(String configKey, Level logLevel, Resp
 
     @Override
     protected void log(String configKey, String format, Object... args) {
-      logger.fine(String.format(methodTag(configKey) + format, args));
+      if (logger.isLoggable(java.util.logging.Level.FINE)) {
+        logger.fine(String.format(methodTag(configKey) + format, args));
+      }
     }
 
     /**
diff --git a/slf4j/src/main/java/feign/slf4j/Slf4jLogger.java b/slf4j/src/main/java/feign/slf4j/Slf4jLogger.java
@@ -68,6 +68,8 @@ protected Response logAndRebufferResponse(String configKey, Level logLevel, Resp
   protected void log(String configKey, String format, Object... args) {
     // Not using SLF4J's support for parameterized messages (even though it would be more efficient) because it would
     // require the incoming message formats to be SLF4J-specific.
-    logger.debug(String.format(methodTag(configKey) + format, args));
+    if (logger.isDebugEnabled()) {
+      logger.debug(String.format(methodTag(configKey) + format, args));
+    }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,9 @@ protected Response logAndRebufferResponse(String configKey, Level logLevel, Resp`
`178`	`178`
`179`	`179`	`@Override`
`180`	`180`	`protected void log(String configKey, String format, Object... args) {`
`181`		`- logger.fine(String.format(methodTag(configKey) + format, args));`
	`181`	`+ if (logger.isLoggable(java.util.logging.Level.FINE)) {`
	`182`	`+ logger.fine(String.format(methodTag(configKey) + format, args));`
	`183`	`+ }`
`182`	`184`	`}`
`183`	`185`
`184`	`186`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,8 @@ protected Response logAndRebufferResponse(String configKey, Level logLevel, Resp`
`68`	`68`	`protected void log(String configKey, String format, Object... args) {`
`69`	`69`	`// Not using SLF4J's support for parameterized messages (even though it would be more efficient) because it would`
`70`	`70`	`// require the incoming message formats to be SLF4J-specific.`
`71`		`- logger.debug(String.format(methodTag(configKey) + format, args));`
	`71`	`+ if (logger.isDebugEnabled()) {`
	`72`	`+ logger.debug(String.format(methodTag(configKey) + format, args));`
	`73`	`+ }`
`72`	`74`	`}`
`73`	`75`	`}`