Add comments to FF RGB format fix

Mugen87 · Mugen87 · commit ddff0f642acb · 2016-03-25T11:18:56.000+01:00
diff --git a/examples/js/SimulationRenderer.js b/examples/js/SimulationRenderer.js
@@ -226,7 +226,7 @@ function SimulationRenderer( WIDTH, renderer ) {
 
 		}
 
-		var texture = new THREE.DataTexture( a, WIDTH, WIDTH, THREE.RGBAFormat, THREE.FloatType );
+		var texture = new THREE.DataTexture( a, WIDTH, WIDTH, THREE.RGBAFormat, THREE.FloatType ); // was RGB format. changed to RGBA format. see discussion in #8415 / #8450
 		texture.needsUpdate = true;
 
 		return texture;
diff --git a/examples/js/postprocessing/AdaptiveToneMappingPass.js b/examples/js/postprocessing/AdaptiveToneMappingPass.js
@@ -186,7 +186,8 @@ THREE.AdaptiveToneMappingPass.prototype = {
 			this.previousLuminanceRT.dispose();
 
 		}
-		var pars = { minFilter: THREE.LinearFilter, magFilter: THREE.LinearFilter, format: THREE.RGBAFormat };
+
+		var pars = { minFilter: THREE.LinearFilter, magFilter: THREE.LinearFilter, format: THREE.RGBAFormat }; // was RGB format. changed to RGBA format. see discussion in #8415 / #8450
 
 		this.luminanceRT = new THREE.WebGLRenderTarget( this.resolution, this.resolution, pars );
 		this.luminanceRT.texture.generateMipmaps = false;

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,7 @@ function SimulationRenderer( WIDTH, renderer ) {`
`226`	`226`
`227`	`227`	`}`
`228`	`228`
`229`		`- var texture = new THREE.DataTexture( a, WIDTH, WIDTH, THREE.RGBAFormat, THREE.FloatType );`
	`229`	`+ var texture = new THREE.DataTexture( a, WIDTH, WIDTH, THREE.RGBAFormat, THREE.FloatType ); // was RGB format. changed to RGBA format. see discussion in #8415 / #8450`
`230`	`230`	`texture.needsUpdate = true;`
`231`	`231`
`232`	`232`	`return texture;`
Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,8 @@ THREE.AdaptiveToneMappingPass.prototype = {`
`186`	`186`	`this.previousLuminanceRT.dispose();`
`187`	`187`
`188`	`188`	`}`
`189`		`- var pars = { minFilter: THREE.LinearFilter, magFilter: THREE.LinearFilter, format: THREE.RGBAFormat };`
	`189`	`+`
	`190`	`+ var pars = { minFilter: THREE.LinearFilter, magFilter: THREE.LinearFilter, format: THREE.RGBAFormat }; // was RGB format. changed to RGBA format. see discussion in #8415 / #8450`
`190`	`191`
`191`	`192`	`this.luminanceRT = new THREE.WebGLRenderTarget( this.resolution, this.resolution, pars );`
`192`	`193`	`this.luminanceRT.texture.generateMipmaps = false;`