Skip to content

Commit ddda597

Browse files
committed
UVsDebug: support BufferGeometry
1 parent 8c5a94e commit ddda597

2 files changed

Lines changed: 27 additions & 10 deletions

File tree

examples/js/utils/UVsDebug.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,15 @@
66
* geometries UV mapping
77
*
88
* Sample usage:
9-
* document.body.appendChild(
10-
* THREE.UVsDebug(
11-
* new THREE.SphereGeometry(10,10,10,10));
9+
* document.body.appendChild( THREE.UVsDebug( new THREE.SphereGeometry( 10, 10, 10, 10 ) );
1210
*
1311
*/
1412

1513
THREE.UVsDebug = function( geometry, size ) {
1614

1715
// handles wrapping of uv.x > 1 only
1816

19-
var abc = 'abcd';
17+
var abc = 'abc';
2018

2119
var uv, u, ax, ay;
2220
var i, il, j, jl;
@@ -25,8 +23,10 @@ THREE.UVsDebug = function( geometry, size ) {
2523
var a = new THREE.Vector2();
2624
var b = new THREE.Vector2();
2725

28-
var faces = geometry.faces;
29-
var uvs = geometry.faceVertexUvs[ 0 ];
26+
var geo = ( geometry instanceof THREE.BufferGeometry ) ? new THREE.Geometry().fromBufferGeometry( geometry ) : geometry;
27+
28+
var faces = geo.faces;
29+
var uvs = geo.faceVertexUvs[ 0 ];
3030

3131
var canvas = document.createElement( 'canvas' );
3232
var width = size || 1024; // power of 2 required for wrapping

examples/misc_uv_tests.html

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,26 +4,39 @@
44
<meta charset=utf-8 />
55
<title>three.js - uv mapping tests</title>
66
</head>
7+
78
<body>
9+
810
<script src="../build/three.min.js"></script>
911
<script src="js/utils/UVsDebug.js"></script>
12+
1013
<script>
14+
1115
/*
1216
* This is to help debug UVs problems in geometry,
1317
* as well as allow a new user to visualize what UVs are about.
1418
*/
1519

1620
function test(name, geometry) {
17-
var d = document.createElement('div');
21+
22+
var d = document.createElement( 'div' );
23+
1824
d.innerHTML = '<br><br>' + name + '<br>';
19-
d.appendChild(THREE.UVsDebug(geometry));
20-
document.body.appendChild(d);
25+
26+
d.appendChild( THREE.UVsDebug( geometry ) );
27+
28+
document.body.appendChild( d );
29+
2130
}
2231

2332
test('new THREE.PlaneGeometry( 100, 100, 4, 4 )', new THREE.PlaneGeometry( 100, 100, 4, 4 ));
33+
34+
test('new THREE.PlaneBufferGeometry( 100, 100, 4, 4 )', new THREE.PlaneBufferGeometry( 100, 100, 4, 4 ));
35+
2436
test('new THREE.SphereGeometry( 75, 12, 6 )', new THREE.SphereGeometry( 75, 12, 6 ));
2537

2638
test('new THREE.IcosahedronGeometry( 30, 1 )', new THREE.IcosahedronGeometry( 30, 1 ));
39+
2740
test('new THREE.OctahedronGeometry( 30, 2 )', new THREE.OctahedronGeometry( 30, 2 ));
2841

2942
test('new THREE.CylinderGeometry( 25, 75, 100, 10, 5 )', new THREE.CylinderGeometry( 25, 75, 100, 10, 5 ));
@@ -38,10 +51,14 @@
3851

3952
}
4053

41-
4254
test('new THREE.LatheGeometry( points, 8 )', new THREE.LatheGeometry( points, 8 ));
55+
4356
test('new THREE.TorusGeometry( 50, 20, 8, 8 )', new THREE.TorusGeometry( 50, 20, 8, 8 ));
57+
4458
test('new THREE.TorusKnotGeometry( 50, 10, 12, 6 )', new THREE.TorusKnotGeometry( 50, 10, 12, 6 ));
59+
4560
</script>
61+
4662
</body>
63+
4764
</html>

0 commit comments

Comments
 (0)