Skip to content

Commit d3a88f2

Browse files
committed
Removed cameraElement.removeChild() from youtube example and minor refactoring.
1 parent 5c803e2 commit d3a88f2

1 file changed

Lines changed: 18 additions & 23 deletions

File tree

examples/css3d_youtube.html

Lines changed: 18 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555

5656
<script>
5757
var camera, scene, renderer;
58-
var objects = [], player;
58+
var player;
5959

6060
var auto = true;
6161

@@ -94,7 +94,6 @@
9494
// object.position.y = Math.random() * 2000 - 1000;
9595
object.position.y = 3000;
9696
object.position.z = Math.random() * - 5000;
97-
scene.add( object );
9897

9998
//
10099

@@ -242,30 +241,25 @@
242241

243242
window.location.hash = query;
244243

245-
for ( var i = 0, l = objects.length; i < l; i ++ ) {
244+
for ( var i = 0, l = scene.children.length; i < l; i ++ ) {
246245

247-
var object = objects[ i ];
248-
var delay = Math.random() * 1000;
246+
( function () {
249247

250-
new TWEEN.Tween( object.position )
251-
.to( { y: - 3000 }, 1000 )
252-
.delay( delay )
253-
.easing( TWEEN.Easing.Exponential.In )
254-
.start();
248+
var object = scene.children[ i ];
249+
var delay = Math.random() * 100;
255250

256-
new TWEEN.Tween( object )
257-
.to( {}, 2000 )
258-
.delay( delay )
259-
.onComplete( function () {
251+
new TWEEN.Tween( object.position )
252+
.to( { y: - 2000 }, 1000 )
253+
.delay( delay )
254+
.easing( TWEEN.Easing.Exponential.In )
255+
.onComplete( function () {
260256

261-
scene.remove( this );
262-
renderer.cameraElement.removeChild( this.element );
257+
scene.remove( object );
263258

264-
var index = objects.indexOf( this );
265-
objects.splice( index, 1 );
259+
} )
260+
.start();
266261

267-
} )
268-
.start();
262+
} )();
269263

270264
}
271265

@@ -285,17 +279,18 @@
285279

286280
for ( var i = 0; i < entries.length; i ++ ) {
287281

288-
objects.push( new Element( entries[ i ] ) );
282+
var object = new Element( entries[ i ] );
283+
scene.add( object );
289284

290285
}
291286

292287
}
293288

294289
function move( delta ) {
295290

296-
for ( var i = 0; i < objects.length; i ++ ) {
291+
for ( var i = 0; i < scene.children.length; i ++ ) {
297292

298-
var object = objects[ i ];
293+
var object = scene.children[ i ];
299294

300295
object.position.z += delta;
301296

0 commit comments

Comments
 (0)