Skip to content

Commit c78e8c8

Browse files
committed
Geometry browser - WireframeGeometry + removed switch
1 parent 9e2c304 commit c78e8c8

2 files changed

Lines changed: 31 additions & 101 deletions

File tree

docs/scenes/geometry-browser.html

Lines changed: 23 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -80,30 +80,33 @@
8080
scene.add( lights[1] );
8181
scene.add( lights[2] );
8282

83-
var mesh = THREE.SceneUtils.createMultiMaterialObject(
83+
var mesh = new THREE.Object3D()
84+
85+
mesh.add( new THREE.LineSegments(
86+
87+
new THREE.Geometry(),
88+
89+
new THREE.LineBasicMaterial({
90+
color: 0xffffff,
91+
side: THREE.DoubleSide,
92+
transparent: true,
93+
opacity: 0.5
94+
})
95+
96+
));
97+
98+
mesh.add( new THREE.Mesh(
8499

85100
new THREE.Geometry(),
86101

87-
[
88-
89-
new THREE.MeshBasicMaterial({
90-
color: 0xffffff,
91-
side: THREE.DoubleSide,
92-
wireframe: true,
93-
transparent: true,
94-
opacity: 0.5
95-
}),
96-
97-
new THREE.MeshPhongMaterial({
98-
color: 0x156289,
99-
emissive: 0x072534,
100-
side: THREE.DoubleSide,
101-
shading: THREE.FlatShading
102-
})
103-
104-
]
102+
new THREE.MeshPhongMaterial({
103+
color: 0x156289,
104+
emissive: 0x072534,
105+
side: THREE.DoubleSide,
106+
shading: THREE.FlatShading
107+
})
105108

106-
);
109+
));
107110

108111
var options = chooseFromHash( mesh );
109112

docs/scenes/js/geometry.js

Lines changed: 8 additions & 81 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ function updateGroupGeometry( mesh, geometry ) {
8585
mesh.children[0].geometry.dispose();
8686
mesh.children[1].geometry.dispose();
8787

88-
mesh.children[0].geometry = geometry
89-
mesh.children[1].geometry = geometry.clone()
88+
mesh.children[0].geometry = new THREE.WireframeGeometry( geometry );
89+
mesh.children[1].geometry = geometry;
9090

9191
//these do not update nicely together if shared
9292
}
@@ -531,91 +531,18 @@ function chooseFromHash ( mesh ) {
531531

532532
var selectedGeometry = window.location.hash.substring(1) || "TorusGeometry";
533533

534-
switch (selectedGeometry) {
534+
if ( guis[ selectedGeometry ] !== undefined ) {
535535

536-
case "BoxGeometry" :
536+
guis[ selectedGeometry ]( mesh );
537537

538-
guis.BoxGeometry( mesh )
539-
540-
break;
541-
542-
case "CircleGeometry" :
543-
544-
guis.CircleGeometry( mesh )
545-
546-
break;
547-
548-
case "CylinderGeometry" :
549-
550-
guis.CylinderGeometry( mesh )
551-
552-
break;
553-
554-
case "PlaneGeometry" :
555-
556-
guis.PlaneGeometry( mesh )
557-
558-
break;
559-
560-
case "RingGeometry" :
561-
562-
guis.RingGeometry( mesh )
563-
564-
break;
565-
566-
case "SphereGeometry" :
567-
568-
guis.SphereGeometry( mesh )
569-
570-
break;
571-
572-
case "TextGeometry" :
573-
574-
guis.TextGeometry( mesh )
575-
576-
return {
577-
fixed : true
578-
};
579-
580-
break;
581-
582-
case "TorusGeometry" :
583-
584-
guis.TorusGeometry( mesh )
585-
586-
break;
587-
588-
case "TorusKnotGeometry" :
589-
590-
guis.TorusKnotGeometry( mesh )
591-
592-
break;
593-
594-
case "DodecahedronGeometry" :
595-
596-
guis.DodecahedronGeometry( mesh )
597-
598-
break;
599-
600-
case "IcosahedronGeometry" :
601-
602-
guis.IcosahedronGeometry( mesh )
603-
604-
break;
605-
606-
case "OctahedronGeometry" :
607-
608-
guis.OctahedronGeometry( mesh )
538+
}
609539

610-
break;
611-
612-
case "TetrahedronGeometry" :
540+
if ( selectedGeometry === 'TextGeometry' ) {
613541

614-
guis.TetrahedronGeometry( mesh )
542+
return { fixed : true };
615543

616-
break;
617544
}
618-
545+
619546
//No configuration options
620547
return {};
621548

0 commit comments

Comments
 (0)