SceneLoader: setting visibility of implicitly created children to explicitly specified visibility in JSON.

alteredq · alteredq · commit a32ee687cd3f · 2012-12-14T22:15:07.000+01:00
This is for toggling visibility in hierarchy models loaded from OBJ, UTF8, etc. where in JSON there is just a root node.
diff --git a/build/three.js b/build/three.js
@@ -10378,6 +10378,9 @@ THREE.SceneLoader.prototype.parse = function ( json, callbackFinished, url ) {
 
 		node.scale.set( s[0], s[1], s[2] );
 
+		// override children materials
+		// if object material was specified in JSON explicitly
+
 		if ( material ) {
 
 			node.traverse( function ( child )  {
@@ -10388,6 +10391,17 @@ THREE.SceneLoader.prototype.parse = function ( json, callbackFinished, url ) {
 
 		}
 
+		// override children visibility
+		// with root node visibility as specified in JSON
+
+		var visible = ( obj.visible !== undefined ) ? obj.visible : true;
+
+		node.traverse( function ( child )  {
+
+			child.visible = visible;
+
+		} );
+
 		parent.add( node );
 
 		node.name = id;
diff --git a/build/three.min.js b/build/three.min.js
diff --git a/src/loaders/SceneLoader.js b/src/loaders/SceneLoader.js
@@ -534,6 +534,9 @@ THREE.SceneLoader.prototype.parse = function ( json, callbackFinished, url ) {
 
 		node.scale.set( s[0], s[1], s[2] );
 
+		// override children materials
+		// if object material was specified in JSON explicitly
+
 		if ( material ) {
 
 			node.traverse( function ( child )  {
@@ -544,6 +547,17 @@ THREE.SceneLoader.prototype.parse = function ( json, callbackFinished, url ) {
 
 		}
 
+		// override children visibility
+		// with root node visibility as specified in JSON
+
+		var visible = ( obj.visible !== undefined ) ? obj.visible : true;
+
+		node.traverse( function ( child )  {
+
+			child.visible = visible;
+
+		} );
+
 		parent.add( node );
 
 		node.name = id;
