Skip to content

Commit 639c55f

Browse files
committed
Merge pull request mrdoob#6494 from brason/patch-3
Fix instancing examples
2 parents b10e205 + 9e322bc commit 639c55f

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

examples/webgl_buffergeometry_instancing.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@
145145

146146
var offsets = new THREE.InstancedBufferAttribute( new Float32Array( instances * 3 ), 3, 1, false );
147147

148-
for ( var i = 0, ul = offsets.length / 3; i < ul; i++ ) {
148+
for ( var i = 0, ul = offsets.length; i < ul; i++ ) {
149149

150150
offsets.setXYZ( i, Math.random() - 0.5, Math.random() - 0.5, Math.random() - 0.5 );
151151

@@ -155,7 +155,7 @@
155155

156156
var colors = new THREE.InstancedBufferAttribute( new Float32Array( instances * 4 ), 4, 1, false );
157157

158-
for ( var i = 0, ul = colors.length / 4; i < ul; i++ ) {
158+
for ( var i = 0, ul = colors.length; i < ul; i++ ) {
159159

160160
colors.setXYZW( i, Math.random(), Math.random(), Math.random(), Math.random() );
161161

@@ -167,7 +167,7 @@
167167

168168
var orientationsStart = new THREE.InstancedBufferAttribute( new Float32Array( instances * 4 ), 4, 1, false );
169169

170-
for ( var i = 0, ul = orientationsStart.length / 4; i < ul; i++ ) {
170+
for ( var i = 0, ul = orientationsStart.length; i < ul; i++ ) {
171171

172172
vector.set( Math.random() * 2 - 1, Math.random() * 2 - 1, Math.random() * 2 - 1, Math.random() * 2 - 1 );
173173
vector.normalize();
@@ -180,7 +180,7 @@
180180

181181
var orientationsEnd = new THREE.InstancedBufferAttribute( new Float32Array( instances * 4 ), 4, 1, false );
182182

183-
for ( var i = 0, ul = orientationsEnd.length / 4; i < ul; i++ ) {
183+
for ( var i = 0, ul = orientationsEnd.length; i < ul; i++ ) {
184184

185185
vector.set( Math.random() * 2 - 1, Math.random() * 2 - 1, Math.random() * 2 - 1, Math.random() * 2 - 1 );
186186
vector.normalize();

examples/webgl_buffergeometry_instancing_dynamic.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@
213213
var offsets = new THREE.InstancedBufferAttribute( new Float32Array( instances * 3 ), 3, 1, false );
214214

215215
var vector = new THREE.Vector4();
216-
for ( var i = 0, ul = offsets.length / 3; i < ul; i++ ) {
216+
for ( var i = 0, ul = offsets.length; i < ul; i++ ) {
217217
var x = Math.random() * 100 - 50;
218218
var y = Math.random() * 100 - 50;
219219
var z = Math.random() * 100 - 50;
@@ -228,7 +228,7 @@
228228

229229
orientations = new THREE.InstancedBufferAttribute( new Float32Array( instances * 4 ), 4, 1, true );
230230

231-
for ( var i = 0, ul = orientations.length / 4; i < ul; i++ ) {
231+
for ( var i = 0, ul = orientations.length; i < ul; i++ ) {
232232

233233
vector.set( Math.random() * 2 - 1, Math.random() * 2 - 1, Math.random() * 2 - 1, Math.random() * 2 - 1 );
234234
vector.normalize();
@@ -318,7 +318,7 @@
318318
var delta = ( time - lastTime ) / 5000;
319319
tmpQ.set( moveQ.x * delta, moveQ.y * delta, moveQ.z * delta, 1 ).normalize();
320320

321-
for ( var i = 0, ul = orientations.length / 4; i < ul; i++ ) {
321+
for ( var i = 0, ul = orientations.length; i < ul; i++ ) {
322322
var index = i * 4;
323323
currentQ.set( orientations.array[index], orientations.array[index + 1], orientations.array[index + 2], orientations.array[index + 3] );
324324
currentQ.multiply( tmpQ );
@@ -338,4 +338,4 @@
338338

339339

340340

341-
</html>
341+
</html>

0 commit comments

Comments
 (0)