Skip to content

Commit 5cf791f

Browse files
cnspahamrdoob
authored andcommitted
Add dispose function to VREffect. Otherwise it causes a memory leak if it is instantiated several times -> always add eventlistener on window (mrdoob#9787)
1 parent 397fc18 commit 5cf791f

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

examples/js/effects/VREffect.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,10 @@ THREE.VREffect = function ( renderer, onError ) {
137137

138138
window.addEventListener( 'vrdisplaypresentchange', onVRDisplayPresentChange, false );
139139

140+
this.dispose = function () {
141+
window.removeEventListener( 'vrdisplaypresentchange', onVRDisplayPresentChange, false );
142+
};
143+
140144
this.setFullScreen = function ( boolean ) {
141145

142146
return new Promise( function ( resolve, reject ) {

0 commit comments

Comments
 (0)