Skip to content

Commit 4f98d35

Browse files
Rich-Harrismrdoob
Rich-Harris
authored and
mrdoob
committed
Remove unused is* properties (mrdoob#9381)
* move is* properties to prototypes and remove unused ones * rebuild * merge dev -> less-is * remove rebuild from PR
1 parent bdea7d0 commit 4f98d35

File tree

199 files changed

+599
-700
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

199 files changed

+599
-700
lines changed

‎build/three.js‎

Lines changed: 257 additions & 281 deletions
Large diffs are not rendered by default.

‎build/three.min.js‎

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/animation/AnimationAction.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import { WrapAroundEnding, ZeroCurvatureEnding, ZeroSlopeEnding, LoopPingPong, L
1212
*/
1313

1414
function AnimationAction() {
15-
this.isAnimationAction = true;
1615

1716
throw new Error( "THREE.AnimationAction: " +
1817
"Use mixer.clipAction for construction." );
@@ -664,4 +663,4 @@ AnimationAction._new.prototype = {
664663

665664

666665

667-
export { AnimationAction };
666+
export { AnimationAction };

‎src/animation/AnimationClip.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import { _Math } from '../math/Math';
1414
*/
1515

1616
function AnimationClip( name, duration, tracks ) {
17-
this.isAnimationClip = true;
1817

1918
this.name = name;
2019
this.tracks = tracks;
@@ -367,4 +366,4 @@ Object.assign( AnimationClip, {
367366
} );
368367

369368

370-
export { AnimationClip };
369+
export { AnimationClip };

‎src/animation/AnimationMixer.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import { AnimationClip } from './AnimationClip';
1616
*/
1717

1818
function AnimationMixer( root ) {
19-
this.isAnimationMixer = true;
2019

2120
this._root = root;
2221
this._initMemoryManager();
@@ -745,4 +744,4 @@ Object.assign( AnimationMixer.prototype, {
745744
} );
746745

747746

748-
export { AnimationMixer };
747+
export { AnimationMixer };

‎src/animation/AnimationObjectGroup.js‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import { _Math } from '../math/Math';
3333
*/
3434

3535
function AnimationObjectGroup( var_args ) {
36-
this.isAnimationObjectGroup = true;
3736

3837
this.uuid = _Math.generateUUID();
3938

@@ -76,6 +75,8 @@ AnimationObjectGroup.prototype = {
7675

7776
constructor: AnimationObjectGroup,
7877

78+
isAnimationObjectGroup: true,
79+
7980
add: function( var_args ) {
8081

8182
var objects = this._objects,
@@ -373,4 +374,4 @@ AnimationObjectGroup.prototype = {
373374

374375

375376

376-
export { AnimationObjectGroup };
377+
export { AnimationObjectGroup };

‎src/animation/KeyframeTrackConstructor.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { AnimationUtils } from './AnimationUtils';
22

33
function KeyframeTrackConstructor( name, times, values, interpolation ) {
4-
this.isKeyframeTrack = true;
54

65
if( name === undefined ) throw new Error( "track name is undefined" );
76

@@ -23,4 +22,4 @@ function KeyframeTrackConstructor( name, times, values, interpolation ) {
2322

2423
}
2524

26-
export { KeyframeTrackConstructor };
25+
export { KeyframeTrackConstructor };

‎src/animation/PropertyBinding.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
*/
1010

1111
function PropertyBinding( rootNode, path, parsedPath ) {
12-
this.isPropertyBinding = true;
1312

1413
this.path = path;
1514
this.parsedPath = parsedPath ||
@@ -655,4 +654,4 @@ PropertyBinding.findNode = function( root, nodeName ) {
655654
};
656655

657656

658-
export { PropertyBinding };
657+
export { PropertyBinding };

‎src/animation/PropertyMixer.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import { Quaternion } from '../math/Quaternion';
1111
*/
1212

1313
function PropertyMixer( binding, typeName, valueSize ) {
14-
this.isPropertyMixer = true;
1514

1615
this.binding = binding;
1716
this.valueSize = valueSize;
@@ -206,4 +205,4 @@ PropertyMixer.prototype = {
206205
};
207206

208207

209-
export { PropertyMixer };
208+
export { PropertyMixer };

‎src/animation/tracks/BooleanKeyframeTrack.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import { KeyframeTrackConstructor } from '../KeyframeTrackConstructor';
1313
*/
1414

1515
function BooleanKeyframeTrack( name, times, values ) {
16-
this.isBooleanKeyframeTrack = true;
1716

1817
KeyframeTrackConstructor.call( this, name, times, values );
1918

@@ -39,4 +38,4 @@ BooleanKeyframeTrack.prototype =
3938
} );
4039

4140

42-
export { BooleanKeyframeTrack };
41+
export { BooleanKeyframeTrack };

0 commit comments

Comments
 (0)