Skip to content

Commit 1cdddbb

Browse files
committed
Merge branch 'master' of https://github.com/toji/three.js into dev
Conflicts: examples/js/controls/VRControls.js
2 parents acde16b + 01d7456 commit 1cdddbb

2 files changed

Lines changed: 31 additions & 5 deletions

File tree

examples/js/controls/VRControls.js

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,16 +71,29 @@ THREE.VRControls = function ( object, callback ) {
7171

7272
};
7373

74-
this.zeroSensor = function () {
74+
this.resetSensor = function () {
7575

7676
for ( var i = 0; i < vrInputs.length; i++ ) {
7777

7878
var vrInput = vrInputs[ i ];
7979

80+
if ( vrInput.resetSensor !== undefined ) {
81+
82+
vrInput.resetSensor();
83+
84+
} else if ( vrInput.zeroSensor !== undefined ) {
85+
8086
vrInput.zeroSensor();
8187

8288
}
8389

8490
};
8591

92+
this.zeroSensor = function () {
93+
94+
THREE.warn( 'THREE.VRControls: .zeroSensor() is now .resetSensor().' );
95+
this.resetSensor();
96+
97+
};
98+
8699
};

examples/js/effects/VREffect.js

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,23 @@ THREE.VREffect = function ( renderer, done ) {
4646
if ( devices[i] instanceof HMDVRDevice ) {
4747
vrHMD = devices[i];
4848
self._vrHMD = vrHMD;
49-
self.leftEyeTranslation = vrHMD.getEyeTranslation( "left" );
50-
self.rightEyeTranslation = vrHMD.getEyeTranslation( "right" );
51-
self.leftEyeFOV = vrHMD.getRecommendedEyeFieldOfView( "left" );
52-
self.rightEyeFOV = vrHMD.getRecommendedEyeFieldOfView( "right" );
49+
50+
if ( vrHMD.getEyeParameters !== undefined ) {
51+
var leftEyeParams = vrHMD.getEyeParameters( 'left' );
52+
var rightEyeParams = vrHMD.getEyeParameters( 'right' );
53+
self.leftEyeTranslation = leftEyeParams.eyeTranslation;
54+
self.rightEyeTranslation = rightEyeParams.eyeTranslation;
55+
self.leftEyeFOV = leftEyeParams.recommendedFieldOfView;
56+
self.rightEyeFOV = rightEyeParams.recommendedFieldOfView;
57+
} else {
58+
// TODO: This is an older code path and not spec compliant.
59+
// It should be removed at some point in the near future.
60+
self.leftEyeTranslation = vrHMD.getEyeTranslation( 'left' );
61+
self.rightEyeTranslation = vrHMD.getEyeTranslation( 'right' );
62+
self.leftEyeFOV = vrHMD.getRecommendedEyeFieldOfView( 'left' );
63+
self.rightEyeFOV = vrHMD.getRecommendedEyeFieldOfView( 'right' );
64+
}
65+
5366
break; // We keep the first we encounter
5467
}
5568
}

0 commit comments

Comments
 (0)