Merge pull request microsoft#49319 from Xanewok/related-information-markdown

jrieken · web-flow · commit ff7b9d94e9d9 · 2018-05-07T10:28:45.000+02:00
Don't use code annotations unconditionally for related diagnostics
diff --git a/src/vs/editor/common/services/modelServiceImpl.ts b/src/vs/editor/common/services/modelServiceImpl.ts
@@ -174,8 +174,10 @@ class ModelMarkerHandler {
 				hoverMessage.appendMarkdown('\n');
 				for (const { message, resource, startLineNumber, startColumn } of relatedInformation) {
 					hoverMessage.appendMarkdown(
-						`* [${basename(resource.path)}(${startLineNumber}, ${startColumn})](${resource.toString(false)}#${startLineNumber},${startColumn}): \`${message}\` \n`
+						`* [${basename(resource.path)}(${startLineNumber}, ${startColumn})](${resource.toString(false)}#${startLineNumber},${startColumn}): `
 					);
+					hoverMessage.appendText(`${message}`);
+					hoverMessage.appendMarkdown('\n');
 				}
 				hoverMessage.appendMarkdown('\n');
 			}

Original file line number	Diff line number	Diff line change
`@@ -174,8 +174,10 @@ class ModelMarkerHandler {`
`174`	`174`	`hoverMessage.appendMarkdown('\n');`
`175`	`175`	`for (const { message, resource, startLineNumber, startColumn } of relatedInformation) {`
`176`	`176`	`hoverMessage.appendMarkdown(`
`177`		- `* [${basename(resource.path)}(${startLineNumber}, ${startColumn})](${resource.toString(false)}#${startLineNumber},${startColumn}): \`${message}\` \n`
	`177`	+ `* [${basename(resource.path)}(${startLineNumber}, ${startColumn})](${resource.toString(false)}#${startLineNumber},${startColumn}): `
`178`	`178`	`);`
	`179`	+ hoverMessage.appendText(`${message}`);
	`180`	`+ hoverMessage.appendMarkdown('\n');`
`179`	`181`	`}`
`180`	`182`	`hoverMessage.appendMarkdown('\n');`
`181`	`183`	`}`